Re: svn: /php/php-src/trunk/Zend/ tests/traits/bugs/case-sensitive.phpt tests/traits/conflict001.phpt tests/traits/conflict003.phpt
tests/traits/error_011.phpt tests/traits/error_015.phpt tests/traits/language011.phpt tests/traits/methods_0
| From: | Kalle Sommer Nielsen | Date: | Sun, 12 Dec 2010 16:58:10 +0000 |
| Subject: | Re: svn: /php/php-src/trunk/Zend/ tests/traits/bugs/case-sensitive.phpt tests/traits/conflict001.phpt tests/traits/conflict003.phpt tests/traits/error_011.phpt tests/traits/error_015.phpt tests/traits/language011.phpt tests/traits/methods_0 |
||
| Groups: | php.cvs | ||
| Request: | Send a blank email to php-cvs+get-64103@lists.php.net to get a copy of this message | ||
Hi Stefan
2010/12/12 Stefan Marr <gron@php.net>:
> Modified: php/php-src/trunk/Zend/zend_compile.c
> ===================================================================
> --- php/php-src/trunk/Zend/zend_compile.c 2010-12-12 16:17:50 UTC (rev 306266)
> +++ php/php-src/trunk/Zend/zend_compile.c 2010-12-12 16:48:02 UTC (rev 306267)
> @@ -3459,7 +3459,7 @@
>
> if (zend_hash_quick_find(&ce->function_table, hash_key->arKey,
> hash_key->nKeyLength, hash_key->h, (void **)&class_fn) == FAILURE
> || class_fn->common.scope != ce) {
> - zend_error(E_WARNING, "Trait method %s has
> not been applied, because there are collisions with other trait methods on %s",
> fn->common.function_name, ce->name);
> + zend_error(E_ERROR, "Trait method %s has
> not been applied, because there are collisions with other trait methods on %s",
> fn->common.function_name, ce->name);
> }
Wouldn't it make more sense to mark this as E_COMPILE_ERROR as it
happens at compilation stage?
--
regards,
Kalle Sommer Nielsen
kalle@php.net