Re: svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/ext/spl/spl_heap.c branches/PHP_5_3/ext/spl/tests/bug53588.phpt trunk/ext/spl/spl_heap.c
trunk/ext/spl/tests/bug53588.phpt
| From: | Gustavo Lopes | Date: | Tue, 21 Dec 2010 19:55:07 +0000 |
| Subject: | Re: svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/ext/spl/spl_heap.c branches/PHP_5_3/ext/spl/tests/bug53588.phpt trunk/ext/spl/spl_heap.c trunk/ext/spl/tests/bug53588.phpt |
||
| References: | 1 2 3 4 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-64195@lists.php.net to get a copy of this message | ||
On Tue, 21 Dec 2010 18:52:07 -0000, Christopher Jones <christopher.jones@oracle.com> wrote:
On 12/21/2010 10:47 AM, Gustavo Lopes wrote:Oops. You're right. I've reversed the change and closed the bug as bogus. Thanks. -- Gustavo LopesOn Tue, 21 Dec 2010 18:23:11 -0000, Christopher Jones <christopher.jones@oracle.com> wrote:That's the definition for SplMaxHeap. The definition for SplMinHeap is "positive integer if value1 is lower than value2". See the link above.Hi Gustavo, Can you review the definition of http://www.php.net/manual/en/splminheap.compare.php ? I believe the testcase should have the operands reversed to satisfy this definition and so the bug was bogus.I did. The definition says compare() should give a positive number if $value1 is larger than $value2, which it does: