Re: svn: /php/php-src/trunk/ Zend/zend.c Zend/zend_compile.c Zend/zend_globals.h Zend/zend_language_scanner.c Zend/zend_language_scanner.h
Zend/zend_language_scanner.l Zend/zend_language_scanner_defs.h Zend/zend_multibyte.c Zend/zend_multibyte.h
ext/mbstring/libmbfl/filters/mbfilter_base64.c ext/mbstring/libmbfl/filters/mbfilter_big5.c ext/mbstring/libmbfl/filters/mbfilter_cp5022x.c
ext/mbstring/libmbfl/filters/mbfilter_cp932.c ext/mbstring/libmbfl/filters/mbfilter_cp936.c ext/mbstring/libmbfl/filte
| From: | Dmitry Stogov | Date: | Thu, 13 Jan 2011 14:32:50 +0000 |
| Subject: | Re: svn: /php/php-src/trunk/ Zend/zend.c Zend/zend_compile.c Zend/zend_globals.h Zend/zend_language_scanner.c Zend/zend_language_scanner.h Zend/zend_language_scanner.l Zend/zend_language_scanner_defs.h Zend/zend_multibyte.c Zend/zend_multibyte.h ext/mbstring/libmbfl/filters/mbfilter_base64.c ext/mbstring/libmbfl/filters/mbfilter_big5.c ext/mbstring/libmbfl/filters/mbfilter_cp5022x.c ext/mbstring/libmbfl/filters/mbfilter_cp932.c ext/mbstring/libmbfl/filters/mbfilter_cp936.c ext/mbstring/libmbfl/filte |
||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-64348@lists.php.net to get a copy of this message | ||
Hi Moriyoshi,
I just came from long vacation and found most of the ext/mbstring related tests failed. Looking into the problems I found a lot of places where PHP crashes because of NULL pointer deference. Some other tests produce incorrect output.
Have you tried to run "make test" with your patch?
Could you please fix the bugs you introduced or revert the patch.
I've attached a patch that fixes some of mbstring crashes.
Thanks. Dmitry.
On 12/19/2010 07:36 PM, Moriyoshi Koizumi wrote:
Attachment: [text/x-patch] mb_fix.diff
moriyoshi Sun, 19 Dec 2010 16:36:37 +0000Revision: http://svn.php.net/viewvc?view=revision&revision=306453 Log: * Refactor zend_multibyte facility. Now mbstring.script_encoding is superseded by zend.script_encoding. Changed paths: <changed paths exceeded maximum size>
Attachment: [text/x-patch] mb_fix.diff