Re: cvs: php4 /ext/domxml php_domxml.c

From: Date: Tue, 31 Jul 2001 07:40:42 +0000
Subject: Re: cvs: php4 /ext/domxml php_domxml.c
References: 1  Groups: php.cvs 
Request: Send a blank email to php-cvs+get-6440@lists.php.net to get a copy of this message
I know.. I just got lazy. I was hoping Zeev fixes it later. :) --Jani On Mon, 30 Jul 2001, Andi Gutmans wrote: >Jani, > >A better fix would be to pass TSRMLS_CC to the get_object functions instead >of re-fetching them each time. > >Andi > >At 08:11 PM 7/30/2001 +0000, Jani Taskinen wrote: >>sniper Mon Jul 30 16:11:28 2001 EDT >> >> Modified files: >> /php4/ext/domxml php_domxml.c >> Log: >> Make this compile in ZTS mode. >> >>Index: php4/ext/domxml/php_domxml.c >>diff -u php4/ext/domxml/php_domxml.c:1.42 php4/ext/domxml/php_domxml.c:1.43 >>--- php4/ext/domxml/php_domxml.c:1.42 Sun Jul 29 21:56:23 2001 >>+++ php4/ext/domxml/php_domxml.c Mon Jul 30 16:11:28 2001 >>@@ -16,7 +16,7 @@ >> +----------------------------------------------------------------------+ >> */ >> >>-/* $Id: php_domxml.c,v 1.42 2001/07/30 01:56:23 zeev Exp $ */ >>+/* $Id: php_domxml.c,v 1.43 2001/07/30 20:11:28 sniper Exp $ */ >> >> >> #ifdef HAVE_CONFIG_H >>@@ -391,7 +391,8 @@ >> void *obj; >> zval **handle; >> int type; >>- >>+ TSRMLS_FETCH(); >>+ >> if (Z_TYPE_P(wrapper) != IS_OBJECT) { >> php_error(E_ERROR, "Wrapper is not an object"); >> } >>@@ -470,7 +471,8 @@ >> void *obj; >> zval **handle; >> int type; >>- >>+ TSRMLS_FETCH(); >>+ >> if (Z_TYPE_P(wrapper) != IS_OBJECT) { >> php_error(E_ERROR, "Wrapper is not an object"); >> } >>@@ -549,6 +551,7 @@ >> void *obj; >> zval **handle; >> int type; >>+ TSRMLS_FETCH(); >> >> if (Z_TYPE_P(wrapper) != IS_OBJECT) { >> php_error(E_ERROR, "Wrapper is not an object"); >> >> >> >>-- >>PHP CVS Mailing List (http://www.php.net/) >>To unsubscribe, e-mail: php-cvs-unsubscribe@lists.php.net >>For additional commands, e-mail: php-cvs-help@lists.php.net >>To contact the list administrators, e-mail: php-list-admin@lists.php.net > > >

« previous php.cvs (#6440) next »