Re: cvs: php4 /ext/zlib zlib.c

I don't think it is obvious that you should be able to use URL's in gzopen(). It's not that useful and I really prefer to keep things more on the simple side. How about passing it the IGNORE_URL flag? Anyway, I thought that was the default that's the bug crept in. Andi At 11:25 06/07/00 +0000, Thies C. Arntzen wrote:

thies           Thu Jul  6 04:25:24 2000 EDT

Modified files:

    /php4/ext/zlib      zlib.c

Log: @- Fixed crash in gzopen(). (Thies) # hmm - this should be rethought as one should be able to do # gzopen("http://..") Index: php4/ext/zlib/zlib.c diff -u php4/ext/zlib/zlib.c:1.50 php4/ext/zlib/zlib.c:1.51 --- php4/ext/zlib/zlib.c:1.50 Mon Jun 26 11:19:35 2000

+++ php4/ext/zlib/zlib.c        Thu Jul  6 04:25:24 2000

@@ -16,7 +16,7 @@

    |          Stefan Röhrich <sr@linux.de>                                |
    +----------------------------------------------------------------------+

*/ -/* $Id: zlib.c,v 1.50 2000/06/26 18:19:35 andi Exp $ */ +/* $Id: zlib.c,v 1.51 2000/07/06 11:25:24 thies Exp $ */ #define IS_EXT_MODULE #include "php.h" @@ -153,8 +153,9 @@ static gzFile php_gzopen_wrapper(char *path, char *mode, int options) {

        FILE *f;
+       int issock=0, socketd=0;

-       f = php_fopen_wrapper(path, mode, options, NULL, NULL, NULL);
+       f = php_fopen_wrapper(path, mode, options, &issock, &socketd, NULL);

        if (!f) {
                return NULL;

-- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, e-mail: php-cvs-unsubscribe@lists.php.net For additional commands, e-mail: php-cvs-help@lists.php.net To contact the list administrators, e-mail: php-list-admin@lists.php.net

--- Andi Gutmans <andi@zend.com> http://www.zend.com/