svn: /php/php-src/ branches/PHP_5_3/ext/interbase/interbase.c trunk/ext/interbase/interbase.c
| From: | Felipe Pena | Date: | Thu, 24 Feb 2011 02:42:38 +0000 |
| Subject: | svn: /php/php-src/ branches/PHP_5_3/ext/interbase/interbase.c trunk/ext/interbase/interbase.c | ||
| Groups: | php.cvs | ||
| Request: | Send a blank email to php-cvs+get-64592@lists.php.net to get a copy of this message | ||
felipe Thu, 24 Feb 2011 02:42:38 +0000
Revision: http://svn.php.net/viewvc?view=revision&revision=308618
Log:
- Fixed possible off-by-one overflow in ibase_gen_id()
Changed paths:
U php/php-src/branches/PHP_5_3/ext/interbase/interbase.c
U php/php-src/trunk/ext/interbase/interbase.c
Modified: php/php-src/branches/PHP_5_3/ext/interbase/interbase.c
===================================================================
--- php/php-src/branches/PHP_5_3/ext/interbase/interbase.c 2011-02-23 22:21:51 UTC (rev 308617)
+++ php/php-src/branches/PHP_5_3/ext/interbase/interbase.c 2011-02-24 02:42:38 UTC (rev 308618)
@@ -1424,6 +1424,11 @@
&inc, &link)) {
RETURN_FALSE;
}
+
+ if (gen_len > 31) {
+ php_error_docref(NULL TSRMLS_CC, E_WARNING, "Invalid generator name");
+ RETURN_FALSE;
+ }
PHP_IBASE_LINK_TRANS(link, ib_link, trans);
Modified: php/php-src/trunk/ext/interbase/interbase.c
===================================================================
--- php/php-src/trunk/ext/interbase/interbase.c 2011-02-23 22:21:51 UTC (rev 308617)
+++ php/php-src/trunk/ext/interbase/interbase.c 2011-02-24 02:42:38 UTC (rev 308618)
@@ -1424,6 +1424,11 @@
&inc, &link)) {
RETURN_FALSE;
}
+
+ if (gen_len > 31) {
+ php_error_docref(NULL TSRMLS_CC, E_WARNING, "Invalid generator name");
+ RETURN_FALSE;
+ }
PHP_IBASE_LINK_TRANS(link, ib_link, trans);