Re: svn: /php/php-src/trunk/ext/snmp/ snmp.c

It is a pain to run it on FreeBSD, there is a bug in run-tests.php: =============== --- run-tests.php (revision 308673) +++ run-tests.php (working copy) @@ -567,7 +567,7 @@ case 'm': $leak_check = true; $valgrind_cmd = "valgrind --version"; - $valgrind_header = system_with_timeout($valgrind_cmd); + $valgrind_header = system_with_timeout($valgrind_cmd, $_ENV); $replace_count = 0; if (!$valgrind_header) { error("Valgrind returned no version info, cannot proceed.\nPlease check if Valgrind is installed."); =============== Without $_ENV system_with_timeout() will use bogus(system default) PATH environment variable and will not find valgrind executable. After fixing run-tests.php all 27 tests for ext/snmp passed with valgrind enabled. On Sat, Feb 26, 2011 at 10:19 PM, Pierre Joye <pierre.php@gmail.com> wrote: > btw, you can use valgrind as well with the tests suite. That should > help you to catch other possible leaks or bad memory access. > > On Sat, Feb 26, 2011 at 8:08 PM, Boris Lytochkin <lytboris@php.net> wrote: >> lytboris                                 Sat, 26 Feb 2011 19:08:55 +0000 >> >> Revision: L
Ý >> Ðe@«œ4âF±f1http://svn.php.net/viewvc?view=revision&revision=308710 >> >> Log: >> remove compiler warnings >> fix various memory leaks seen with --enable-debug >> >> Changed paths: >>    U   php/php-src/trunk/ext/snmp/snmp.c > -- > Pierre > > @pierrejoye | http://blog.thepimp.net | > http://www.libgd.org > -- Boris Lytochkin