Re: svn: /php/php-src/trunk/win32/build/ Makefile config.w32

hi, On Wed, Mar 2, 2011 at 7:35 PM, Moriyoshi Koizumi <mozo@mozo.jp> wrote: >> Please merge to 5.3 > > Done. Thanks! >> On Wed, Mar 2, 2011 at 6:22 AM, Moriyoshi Koizumi <moriyoshi@php.net> wrote: >>> moriyoshi                                Wed, 02 Mar 2011 05:22:22 >>> +0000 >> >>> Modified: php/php-src/trunk/win32/build/config.w32 >>> =================================================================== >>> --- php/php-src/trunk/win32/build/config.w32    2011-03-02 03:59:38 UTC (rev 308838) >>> +++ php/php-src/trunk/win32/build/config.w32    2011-03-02 05:22:22 UTC (rev 308839) >>> @@ -271,7 +271,7 @@ >>>  var php_usual_lib_suspects = PHP_PHP_BUILD+"\\lib"; >>> >>>  ADD_FLAG("CFLAGS", '/I "' + php_usual_include_suspects + >>> '" '); >>> -ADD_FLAG("LDFLAGS", '/libpath:"\\"' + >>> php_usual_lib_suspects + '\\"" '); >>> +ADD_FLAG("LDFLAGS", '/libpath:"' + php_usual_lib_suspects + >>> '" '); >> >> Why this change? > > The library path needs to be quoted just once. It appears old compiler > frontends (VC6, 7?) used to have a bug with which arguments to the > linker containing whitespaces weren't properly dealt with. Did you test this specific change with VC6? Cheers -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org