Re: cvs: php4 / README.EXT_SKEL /ext/skeleton create_stubs

This still isn't right. The skeleton.h also needs fixing (not sure if anything else too). Andi At 05:36 AM 8/2/2001 +0000, Rasmus Lerdorf wrote:

rasmus          Thu Aug  2 01:36:51 2001 EDT

Modified files:

    /php4       README.EXT_SKEL
    /php4/ext/skeleton  create_stubs

Log: TSRM fix for ext_skel - probably more needed Index: php4/README.EXT_SKEL diff -u php4/README.EXT_SKEL:1.5 php4/README.EXT_SKEL:1.6

--- php4/README.EXT_SKEL:1.5    Tue Oct 31 06:30:10 2000
+++ php4/README.EXT_SKEL        Thu Aug  2 01:36:49 2001

@@ -128,8 +128,8 @@ It can't handle correctly, and probably never will, variable list of of arguments. (void foo(int bar [, ...]) - Don't trust too much the generated code. It tries to be useful in most of - the situations you might encounter, but automatic code generating will never + Don't trust the generated code too much. It tries to be useful in most of + the situations you might encounter, but automatic code generation will never beat a programmer who knows the real situation at hand. ext_skel is generally best suited for quickly generating a wrapper for c-library functions you might want to have available in PHP too. @@ -154,7 +154,7 @@

        int argc;
        int image_id = -1;
        int font_id = -1;
-       ???LS_FETCH();
+       TSRMLS_FETCH();

        argc = ZEND_NUM_ARGS();
        if (argc < 5 || argc > 6 || zend_get_parameters_ex(argc, &image, &text, &font, &x, &y, &color) == FAILURE) {

Index: php4/ext/skeleton/create_stubs diff -u php4/ext/skeleton/create_stubs:1.11 php4/ext/skeleton/create_stubs:1.12 --- php4/ext/skeleton/create_stubs:1.11 Wed Aug 1 20:11:19 2001

+++ php4/ext/skeleton/create_stubs      Thu Aug  2 01:36:50 2001

@@ -272,7 +272,7 @@

                        fetchargs = fetchargs ") == FAILURE)" closefetch "{\n\t\tZEND_WRONG_PARAM_COUNT();\n\t}\n"
                }
                if (assign_params) funcvals = ints doubles floats strings
-               if (resources) funcvals = funcvals "\t???LS_FETCH();\n"
+               if (resources) funcvals = funcvals "\tTSRMLS_FETCH();\n"
                if (useswitch[i]) {
                        if (check_argc_in_switch[i]) {
                                check_argc = "\t\tdefault:\n\t\t\tZEND_WRONG_PARAM_COUNT();\n"

-- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, e-mail: php-cvs-unsubscribe@lists.php.net For additional commands, e-mail: php-cvs-help@lists.php.net To contact the list administrators, e-mail: php-list-admin@lists.php.net