Re: svn: /php/php-src/ branches/PHP_5_3/ext/tidy/tidy.c trunk/ext/tidy/tidy.c

On Mon, Apr 25, 2011 at 9:46 AM, Hannes Magnusson <hannes.magnusson@gmail.com> wrote: > On Mon, Apr 25, 2011 at 00:08, Pierre Joye <pajoye@php.net> wrote: >> pajoye                                   Sun, 24 Apr 2011 22:08:11 +0000 >> >> Revision: >> http://svn.php.net/viewvc?view=revision&revision=310457 >> >> Log: >> - fix use of unitiliazed var >> >> Changed paths: >>    U   php/php-src/branches/PHP_5_3/ext/tidy/tidy.c >>    U   php/php-src/trunk/ext/tidy/tidy.c >> >> Modified: php/php-src/branches/PHP_5_3/ext/tidy/tidy.c >> =================================================================== >> --- php/php-src/branches/PHP_5_3/ext/tidy/tidy.c        2011-04-24 20:47:22 UTC (rev >> 310456) >> +++ php/php-src/branches/PHP_5_3/ext/tidy/tidy.c        2011-04-24 22:08:11 UTC (rev >> 310457) >> @@ -985,10 +985,10 @@ >>                case is_body_node: >>                        node = tidyGetBody(obj->ptdoc->doc); >>                        break; >> -       } >> >> -       if (!node) { >> -               RETURN_NULL(); >> +               default: >> +                       RETURN_NULL(); >> +                       break; > > > What happens if those functions actually fail? There is no functional change here, only that inode is now used only if initialized. The behavior of this code when this function returns NULL remains the same. Cheers, -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org