Re: svn: /php/php-src/ branches/PHP_5_4/NEWS branches/PHP_5_4/ext/standard/filestat.c branches/PHP_5_4/ext/standard/tests/file/userstreams_007.phpt
branches/PHP_5_4/main/php_streams.h branches/PHP_5_4/main/streams/plain_wrapper.c branches/P
| From: | Pierre Joye | Date: | Wed, 25 May 2011 21:59:31 +0000 |
| Subject: | Re: svn: /php/php-src/ branches/PHP_5_4/NEWS branches/PHP_5_4/ext/standard/filestat.c branches/PHP_5_4/ext/standard/tests/file/userstreams_007.phpt branches/PHP_5_4/main/php_streams.h branches/PHP_5_4/main/streams/plain_wrapper.c branches/P |
||
| References: | 1 2 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-65037@lists.php.net to get a copy of this message | ||
hi,
Besides that, did we even approve that change? Gustavo and I were two
that did not like the current implemenation/design.
Cheers,
On Wed, May 25, 2011 at 11:24 PM, Stas Malyshev <smalyshev@gmail.com> wrote:
> Hi!
>
> There seem to be a lot of unrelated code cleanup here, and I am in
>> general a bit confused in this code.
>> Could you review http://php.net/streamwrapper and write up
>> the changes to
>> it?
>>
>>
> There shouldn't be any changes except for adding one stream handler (see
> rfc: https://wiki.php.net/rfc/streammetadata) and adding
> support for it.
> I'll add docs for it soon.
>
--
Pierre
@pierrejoye | http://blog.thepimp.net | http://www.libgd.org