Re: svn: /php/php-src/ branches/PHP_5_4/ext/tokenizer/tokenizer_data.c trunk/ext/tokenizer/tokenizer_data.c
| From: | Hannes Magnusson | Date: | Fri, 03 Jun 2011 13:39:37 +0000 |
| Subject: | Re: svn: /php/php-src/ branches/PHP_5_4/ext/tokenizer/tokenizer_data.c trunk/ext/tokenizer/tokenizer_data.c | ||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-65107@lists.php.net to get a copy of this message | ||
On Fri, Jun 3, 2011 at 03:16, Stanislav Malyshev <stas@php.net> wrote:
> stas Fri, 03 Jun 2011 01:16:01 +0000
>
> Revision:
> http://svn.php.net/viewvc?view=revision&revision=311747
>
> Log:
> and clean the tokenizer too
Are you not actually reverting the previous commits?
There are still some code changes in ext/reflection and zend_compile.c
introduced by the feature.
I have nothing against them, but surely you would want to revert the
original commits to prevent mistakes, rather then go searching the
codebase and rewire it hoping it is enough :)
-Hannes