Re: svn: /php/php-src/ branches/PHP_5_3/ext/standard/basic_functions.c branches/PHP_5_4/ext/standard/basic_functions.c
trunk/ext/standard/basic_functions.c
| From: | Laruence | Date: | Mon, 08 Aug 2011 01:10:43 +0000 |
| Subject: | Re: svn: /php/php-src/ branches/PHP_5_3/ext/standard/basic_functions.c branches/PHP_5_4/ext/standard/basic_functions.c trunk/ext/standard/basic_functions.c |
||
| References: | 1 2 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-65768@lists.php.net to get a copy of this message | ||
Hi:
This was what it was before I edit it. I also don't very sure about it.
and after tracking, I found this statements was introduced in -r243300
diff: http://svn.php.net/viewvc/php/php-src/trunk/ext/standard/basic_functions.c?r1=243098&r2=243300
looks like it was wrong in the rewrite phase,,
I have delete these no sense statements..
thanks
2011/8/8 Stas Malyshev <smalyshev@sugarcrm.com>:
> Hi!
>
> On 8/7/11 7:25 AM, Xinchen Hui wrote:
>>
>> laruence Sun, 07 Aug 2011 14:25:30 +0000
>> memset(opts, 0, count * sizeof(opt_struct));
>>
>> + if (!opts) {
>> + RETURN_FALSE;
>> + }
>> +
>
> I'm not sure I understand this code. You first use opts as memset target and
> then check if for null. How that works?
> --
> Stanislav Malyshev, Software Architect
> SugarCRM: http://www.sugarcrm.com/
> (408)454-6900 ext. 227
>
--
Laruence Xinchen Hui
http://www.laruence.com/