Re: svn: /php/php-src/ branches/PHP_5_3/ext/fileinfo/libmagic/softmagic.c branches/PHP_5_4/ext/fileinfo/libmagic/softmagic.c
trunk/ext/fileinfo/libmagic/softmagic.c
| From: | Kalle Sommer Nielsen | Date: | Mon, 08 Aug 2011 19:36:42 +0000 |
| Subject: | Re: svn: /php/php-src/ branches/PHP_5_3/ext/fileinfo/libmagic/softmagic.c branches/PHP_5_4/ext/fileinfo/libmagic/softmagic.c trunk/ext/fileinfo/libmagic/softmagic.c |
||
| References: | 1 2 3 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-65793@lists.php.net to get a copy of this message | ||
Hi Xinchen
2011/8/8 Laruence <laruence@php.net>:
> Hi all:
>
> trunk/ext/fileinfo/libmagic/softmagic.c seems to be a third-party
> source, I was wondering can I directly modify it?
>
> it can't be compiled with -Wall -Werror, with a lots of warnings..
Yes you can alter the original source thats distributed in php-src,
just remember to update the .patch file in the ext/fileinfo folder so
that when the lib is updated, so is the fix and report upstream if
needed.
--
regards,
Kalle Sommer Nielsen
kalle@php.net