Re: svn: /php/php-src/ branches/PHP_5_3/Zend/zend_builtin_functions.c branches/PHP_5_4/Zend/zend_builtin_functions.c
trunk/Zend/zend_builtin_functions.c
| From: | Pierrick Charron | Date: | Tue, 16 Aug 2011 14:04:47 +0000 |
| Subject: | Re: svn: /php/php-src/ branches/PHP_5_3/Zend/zend_builtin_functions.c branches/PHP_5_4/Zend/zend_builtin_functions.c trunk/Zend/zend_builtin_functions.c |
||
| References: | 1 2 3 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-65874@lists.php.net to get a copy of this message | ||
Maybe we should replace the "unknow" default case of the switch by main ?
Any objection ?
Pierrick
On 16 August 2011 09:55, Pierrick Charron <pierrick@php.net> wrote:
> If you look at the execution flow (and correct me if I'm wrong) :
>
> Line 2118 if the condition is true, then function_name = "unknown";
> if the previous condition is false you have a switch with a
> function_name = "something" in each case.
>
> Pierrick
>
>
> On 16 August 2011 09:47, Hannes Magnusson <hannes.magnusson@gmail.com> wrote:
>> Is that guaranteed 101% by now? See http://php.net/main :)
>>
>> -Hannes
>>
>>
>> On Sun, Aug 7, 2011 at 08:19, Pierrick Charron <pierrick@php.net> wrote:
>>> pierrick Sun, 07 Aug 2011 06:19:43
>>> +0000
>>>
>>> Revision:
>>> http://svn.php.net/viewvc?view=revision&revision=314405
>>>
>>> Log:
>>> function_name cannot be false
>>>
>>> Changed paths:
>>> U php/php-src/branches/PHP_5_3/Zend/zend_builtin_functions.c
>>> U php/php-src/branches/PHP_5_4/Zend/zend_builtin_functions.c
>>> U php/php-src/trunk/Zend/zend_builtin_functions.c
>>>
>>> Modified: php/php-src/branches/PHP_5_3/Zend/zend_builtin_functions.c
>>> ===================================================================
>>> --- php/php-src/branches/PHP_5_3/Zend/zend_builtin_functions.c 2011-08-07 06:15:47
>>> UTC (rev 314404)
>>> +++ php/php-src/branches/PHP_5_3/Zend/zend_builtin_functions.c 2011-08-07 06:19:43
>>> UTC (rev 314405)
>>> @@ -2047,7 +2047,7 @@
>>> ZEND_PUTS(class_name);
>>> ZEND_PUTS(call_type);
>>> }
>>> - zend_printf("%s(",
>>> function_name?function_name:"main");
>>> + zend_printf("%s(", function_name);
>>> if (arg_array) {
>>> debug_print_backtrace_args(arg_array TSRMLS_CC);
>>> zval_ptr_dtor(&arg_array);
>>>
>>> Modified: php/php-src/branches/PHP_5_4/Zend/zend_builtin_functions.c
>>> ===================================================================
>>> --- php/php-src/branches/PHP_5_4/Zend/zend_builtin_functions.c 2011-08-07 06:15:47
>>> UTC (rev 314404)
>>> +++ php/php-src/branches/PHP_5_4/Zend/zend_builtin_functions.c 2011-08-07 06:19:43
>>> UTC (rev 314405)
>>> @@ -2157,7 +2157,7 @@
>>> ZEND_PUTS(class_name);
>>> ZEND_PUTS(call_type);
>>> }
>>> - zend_printf("%s(",
>>> function_name?function_name:"main");
>>> + zend_printf("%s(", function_name);
>>> if (arg_array) {
>>> debug_print_backtrace_args(arg_array TSRMLS_CC);
>>> zval_ptr_dtor(&arg_array);
>>>
>>> Modified: php/php-src/trunk/Zend/zend_builtin_functions.c
>>> ===================================================================
>>> --- php/php-src/trunk/Zend/zend_builtin_functions.c 2011-08-07 06:15:47 UTC (rev
>>> 314404)
>>> +++ php/php-src/trunk/Zend/zend_builtin_functions.c 2011-08-07 06:19:43 UTC (rev
>>> 314405)
>>> @@ -2157,7 +2157,7 @@
>>> ZEND_PUTS(class_name);
>>> ZEND_PUTS(call_type);
>>> }
>>> - zend_printf("%s(",
>>> function_name?function_name:"main");
>>> + zend_printf("%s(", function_name);
>>> if (arg_array) {
>>> debug_print_backtrace_args(arg_array TSRMLS_CC);
>>> zval_ptr_dtor(&arg_array);
>>>
>>>
>>> --
>>> PHP CVS Mailing List (http://www.php.net/)
>>> To unsubscribe, visit: http://www.php.net/unsub.php
>>>
>>
>