Re: svn: /php/php-src/ branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings.phpt trunk/ext/session/tests/rfc1867_invalid_settings.phpt
| From: | Alexey Shein | Date: | Sun, 04 Sep 2011 16:10:51 +0000 |
| Subject: | Re: svn: /php/php-src/ branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings.phpt trunk/ext/session/tests/rfc1867_invalid_settings.phpt | ||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-66173@lists.php.net to get a copy of this message | ||
Hello, why did you fix the test this way? Why not to fix the code and
remove excessive warning?
2011/9/4 Ferenc Kovacs <tyrael@php.net>:
> tyrael Sun, 04 Sep 2011 14:28:52 +0000
>
> Revision:
> http://svn.php.net/viewvc?view=revision&revision=316109
>
> Log:
> passing an invalid session.upload_progress.freq always generates an additional startup error
>
> Changed paths:
> U php/php-src/branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings.phpt
> U php/php-src/trunk/ext/session/tests/rfc1867_invalid_settings.phpt
>
> Modified: php/php-src/branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings.phpt
> ===================================================================
> --- php/php-src/branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings.phpt
> 2011-09-04 14:21:27 UTC (rev 316108)
> +++ php/php-src/branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings.phpt
> 2011-09-04 14:28:52 UTC (rev 316109)
> @@ -9,5 +9,7 @@
> var_dump(ini_get("session.upload_progress.freq"));
> ?>
> --EXPECTF--
> +PHP Warning: PHP Startup: session.upload_progress.freq must be greater than or equal to zero
> in %s
> +
> Warning: PHP Startup: session.upload_progress.freq must be greater than or equal to zero in
> %s
> string(%d) "1%"
>
> Modified: php/php-src/trunk/ext/session/tests/rfc1867_invalid_settings.phpt
> ===================================================================
> --- php/php-src/trunk/ext/session/tests/rfc1867_invalid_settings.phpt 2011-09-04 14:21:27
> UTC (rev 316108)
> +++ php/php-src/trunk/ext/session/tests/rfc1867_invalid_settings.phpt 2011-09-04 14:28:52
> UTC (rev 316109)
> @@ -9,5 +9,7 @@
> var_dump(ini_get("session.upload_progress.freq"));
> ?>
> --EXPECTF--
> +PHP Warning: PHP Startup: session.upload_progress.freq must be greater than or equal to zero
> in %s
> +
> Warning: PHP Startup: session.upload_progress.freq must be greater than or equal to zero in
> %s
> string(%d) "1%"
>
>
> --
> PHP CVS Mailing List (http://www.php.net/)
> To unsubscribe, visit: http://www.php.net/unsub.php
>
--
Regards,
Shein Alexey