Re: svn: /php/php-src/ branches/PHP 5 4/ext/xsl/tests/xsltprocessor registerPHPFunctions-funcnostring.phpt branches/PHP 5
4/ext/xsl/tests/xsltprocessor registerPHPFunctions-funcundef.phpt trunk/ext/xsl/tests/xsltprocessor regi

2011/9/5 Christian Stocker <christian.stocker@liip.ch>: > Hi > > Why did you do that? They're different on purpose. > > I'll revert that, since the tests now fail. > I spotted them on gcov.php.net (it's x64 box, see at the bottom http://gcov.php.net/viewer.php?version=PHP_5_4&func=system), so I checked them on my x64 ubuntu laptop and they were failing too, that's why I fixed them this way. It seems gcov agrees with me, there's no failing xsl tests now: http://gcov.php.net/viewer.php?version=PHP_5_4&func=tests (there are also some troubles with trunk section, it's outdated, maybe because its build is not finished yet after recent downtime, so it needs to be checked further). Now I checked your commit on x86 ubuntu and tests have passed, will check it again on x64-laptop when I got home. > chregu > > On 9/2/11 8:01 PM, Shein Alexey wrote: >> shein                                    Fri, 02 Sep 2011 18:01:20 +0000 >> >> Revision: *sT‚v5¸ >> Í(ñïjhttp://svn.php.net/viewvc?view=revision&revision=316043 >> >> Log: >> Synchronized fixed tests from 5.3 branch. >> >> Changed paths: >>     U   >> php/php-src/branches/PHP_5_4/ext/xsl/tests/xsltprocessor_registerPHPFunctions-funcnostring.phpt >>     U   >> php/php-src/branches/PHP_5_4/ext/xsl/tests/xsltprocessor_registerPHPFunctions-funcundef.phpt >>     U   >> php/php-src/trunk/ext/xsl/tests/xsltprocessor_registerPHPFunctions-funcnostring.phpt >>     U   >> php/php-src/trunk/ext/xsl/tests/xsltprocessor_registerPHPFunctions-funcundef.phpt >> >> Modified: >> php/php-src/branches/PHP_5_4/ext/xsl/tests/xsltprocessor_registerPHPFunctions-funcnostring.phpt >> =================================================================== >> --- >> php/php-src/branches/PHP_5_4/ext/xsl/tests/xsltprocessor_registerPHPFunctions-funcnostring.phpt   >> 2011-09-02 17:56:07 UTC (rev 316042) >> +++ >> php/php-src/branches/PHP_5_4/ext/xsl/tests/xsltprocessor_registerPHPFunctions-funcnostring.phpt   >> 2011-09-02 18:01:20 UTC (rev 316043) >> @@ -21,10 +21,17 @@ >>  $proc->importStylesheet($phpfuncxsl); >>  var_dump($proc->registerPHPFunctions()); >>  var_dump($proc->transformToXml($dom)); >> +?> >>  --EXPECTF-- >>  NULL >> >>  Warning: XSLTProcessor::transformToXml(): Handler name must be a string in %s on line %d >> + >> +Warning: XSLTProcessor::transformToXml(): xmlXPathCompiledEval: evaluation failed in %s on >> line %d >> + >> +Warning: XSLTProcessor::transformToXml(): runtime error: file %s line %d element value-of >> in %s on line %d >> + >> +Warning: XSLTProcessor::transformToXml(): XPath evaluation returned no result. in %s on >> line %d >>  NULL >>  --CREDITS-- >>  Christian Weiske, cweiske@php.net >> >> Modified: >> php/php-src/branches/PHP_5_4/ext/xsl/tests/xsltprocessor_registerPHPFunctions-funcundef.phpt >> =================================================================== >> --- >> php/php-src/branches/PHP_5_4/ext/xsl/tests/xsltprocessor_registerPHPFunctions-funcundef.phpt     >>  2011-09-02 17:56:07 UTC (rev 316042) >> +++ >> php/php-src/branches/PHP_5_4/ext/xsl/tests/xsltprocessor_registerPHPFunctions-funcundef.phpt     >>  2011-09-02 18:01:20 UTC (rev 316043) >> @@ -20,10 +20,17 @@ >>  $proc->importStylesheet($phpfuncxsl); >>  var_dump($proc->registerPHPFunctions()); >>  var_dump($proc->transformToXml($dom)); >> +?> >>  --EXPECTF-- >>  NULL >> >>  Warning: XSLTProcessor::transformToXml(): Unable to call handler undefinedfunc() in %s on >> line %d >> + >> +Warning: XSLTProcessor::transformToXml(): xmlXPathCompiledEval: evaluation failed in %s on >> line %d >> + >> +Warning: XSLTProcessor::transformToXml(): runtime error: file %s line %d element value-of >> in %s on line %d >> + >> +Warning: XSLTProcessor::transformToXml(): XPath evaluation returned no result. in %s on >> line %d >>  NULL >>  --CREDITS-- >>  Christian Weiske, cweiske@php.net >> >> Modified: >> php/php-src/trunk/ext/xsl/tests/xsltprocessor_registerPHPFunctions-funcnostring.phpt >> =================================================================== >> --- php/php-src/trunk/ext/xsl/tests/xsltprocessor_registerPHPFunctions-funcnostring.phpt   >>    2011-09-02 17:56:07 UTC (rev 316042) >> +++ php/php-src/trunk/ext/xsl/tests/xsltprocessor_registerPHPFunctions-funcnostring.phpt   >>    2011-09-02 18:01:20 UTC (rev 316043) >> @@ -21,10 +21,17 @@ >>  $proc->importStylesheet($phpfuncxsl); >>  var_dump($proc->registerPHPFunctions()); >>  var_dump($proc->transformToXml($dom)); >> +?> >>  --EXPECTF-- >>  NULL >> >>  Warning: XSLTProcessor::transformToXml(): Handler name must be a string in %s on line %d >> + >> +Warning: XSLTProcessor::transformToXml(): xmlXPathCompiledEval: evaluation failed in %s on >> line %d >> + >> +Warning: XSLTProcessor::transformToXml(): runtime error: file %s line %d element value-of >> in %s on line %d >> + >> +Warning: XSLTProcessor::transformToXml(): XPath evaluation returned no result. in %s on >> line %d >>  NULL >>  --CREDITS-- >>  Christian Weiske, cweiske@php.net >> >> Modified: php/php-src/trunk/ext/xsl/tests/xsltprocessor_registerPHPFunctions-funcundef.phpt >> =================================================================== >> --- php/php-src/trunk/ext/xsl/tests/xsltprocessor_registerPHPFunctions-funcundef.phpt >> 2011-09-02 17:56:07 UTC (rev 316042) >> +++ php/php-src/trunk/ext/xsl/tests/xsltprocessor_registerPHPFunctions-funcundef.phpt >> 2011-09-02 18:01:20 UTC (rev 316043) >> @@ -20,10 +20,17 @@ >>  $proc->importStylesheet($phpfuncxsl); >>  var_dump($proc->registerPHPFunctions()); >>  var_dump($proc->transformToXml($dom)); >> +?> >>  --EXPECTF-- >>  NULL >> >>  Warning: XSLTProcessor::transformToXml(): Unable to call handler undefinedfunc() in %s on >> line %d >> + >> +Warning: XSLTProcessor::transformToXml(): xmlXPathCompiledEval: evaluation failed in %s on >> line %d >> + >> +Warning: XSLTProcessor::transformToXml(): runtime error: file %s line %d element value-of >> in %s on line %d >> + >> +Warning: XSLTProcessor::transformToXml(): XPath evaluation returned no result. in %s on >> line %d >>  NULL >>  --CREDITS-- >>  Christian Weiske, cweiske@php.net > > -- Regards, Shein Alexey