Re: svn: /php/php-src/ branches/PHP_5_4/NEWS branches/PHP_5_4/Zend/tests/closure_036.phpt branches/PHP_5_4/Zend/tests/closure_038.phpt
branches/PHP_5_4/Zend/tests/closure_039.phpt branches/PHP_5_4/Zend/tests/closure_040.phpt branches/PHP_5_
| From: | Hannes Magnusson | Date: | Wed, 07 Sep 2011 09:38:54 +0000 |
| Subject: | Re: svn: /php/php-src/ branches/PHP_5_4/NEWS branches/PHP_5_4/Zend/tests/closure_036.phpt branches/PHP_5_4/Zend/tests/closure_038.phpt branches/PHP_5_4/Zend/tests/closure_039.phpt branches/PHP_5_4/Zend/tests/closure_040.phpt branches/PHP_5_ |
||
| Groups: | php.cvs | ||
| Request: | Send a blank email to php-cvs+get-66337@lists.php.net to get a copy of this message | ||
On Wed, Sep 7, 2011 at 08:46, Stanislav Malyshev <stas@php.net> wrote:
> stas Wed, 07 Sep 2011 06:46:27 +0000
>
> Revision:
> http://svn.php.net/viewvc?view=revision&revision=316300
>
> Log:
> Commit Gustavo's closure rebinding patch as desided by vote
>
> Changed paths:
> U php/php-src/branches/PHP_5_4/NEWS
> U php/php-src/branches/PHP_5_4/Zend/tests/closure_036..phpt
Modified: php/php-src/branches/PHP_5_4/Zend/tests/closure_036.phpt
===================================================================
--- php/php-src/branches/PHP_5_4/Zend/tests/closure_036.phpt 2011-09-07
05:19:12 UTC (rev 316299)
+++ php/php-src/branches/PHP_5_4/Zend/tests/closure_036.phpt 2011-09-07
06:46:27 UTC (rev 316300)
@@ -1,5 +1,5 @@
--TEST--
-Closure 036: Rebinding closures
+Closure 036: Rebinding closures, keep calling scope
--FILE--
<?php
@@ -20,7 +20,7 @@
$ca = $a->getIncrementor();
$cb = $ca->bindTo($b);
-$cb2 = Closure::bind($b, $ca);
+$cb2 = Closure::bind($ca, $b);
That change seems a bit weird to me and quite big BC break.
Please update the migration file with details on this.
-Hannes