Re: svn: /php/php-src/branches/PHP_5_4/ext/pdo_firebird/ EXPERIMENTAL

On Mon, Sep 12, 2011 at 5:45 PM, Christopher Jones <christopher.jones@oracle.com> wrote: > > > On 9/12/11 4:59 AM, marius adrian popa wrote: >> >> On Mon, Sep 12, 2011 at 11:59 AM, Matteo Beccati<php@beccati.com>  wrote: >>> >>> On 12/09/2011 00:11, Popa Adrian Marius wrote: >>>> >>>> mariuz                                   Sun, 11 Sep 2011 22:11:30 >>>> +0000 >>>> >>>> Revision: >>>> http://svn.php.net/viewvc?view=revision&revision=316506 >>>> >>>> Log: >>>> extension is not experimental anymore >>>> see the status http://www.gn0s1s.nl/?p=108 >>> >>> Is it really so? I was under the impression that there were quite a few >>> issues in the PDO Firebird driver. Not to mention the pretty high number >>> of failing tests... >> >> There are a few issues but less than before (see the status) >> also some of the tests are wrongly written or that doesn't make sense >> for firebird, i will fixe them (they are broken in pdo_odbc too for >> example) >> > > Lester recently submitted patches for tests: > https://bugs.php.net/bug.php?id=55664 This was solved already in svn but for the moment i leave the clean database function (we don't want mess in the tmp folder) db creation/cleanup should be done from pdo and test must be redone anyway > https://bugs.php.net/bug.php?id=55663 for 55663 i will review and apply it after that > Can you review etc.?