Re: svn: /php/php-src/ branches/PHP_5_4/NEWS branches/PHP_5_4/ext/session/config.m4 branches/PHP_5_4/ext/session/config.w32
branches/PHP_5_4/ext/session/mod_user.c branches/PHP_5_4/ext/session/mod_user_class.c branches/PHP_5_4/ext/session/p

On 09/13/2011 06:21 PM, Arpad Ray wrote:

On Wed, Sep 14, 2011 at 1:12 AM, Kalle Sommer Nielsen<kalle@php.net> wrote:

Hi Arpad 2011/9/14 Arpad Ray<arpad@php.net>:

arpad                                    Tue, 13 Sep 2011 22:28:15 +0000

Revision: http://svn.php.net/viewvc?view=revision&revision=316688 Log: Implement object-oriented session handlers (https://wiki.php.net/rfc/session-oo)

Just by skimming over the patch, then all of those is most likely to fail on Windows because you include the forward slash in the path for error messages, whereas on Windows its a backslash. So you want to use: %s<testname>.php instead

Thanks for pointing that out, I've just fixed that test file. :) I haven't been able to test this at all under Windows yet so I'd be very grateful for any further feedback. Regards, Arpad

Arpad, These are now failing for me on Oracle Linux 5.7, 64 bit: Test session_set_save_handler() : basic class wrapping existing handler [ext/session/tests/session_set_save_handler_class_001.phpt] Test session_set_save_handler() : full handler implementation [ext/session/tests/session_set_save_handler_class_002.phpt] Test session_set_save_handler() : inheritance [ext/session/tests/session_set_save_handler_class_003.phpt] Test session_set_save_handler() : default object [ext/session/tests/session_set_save_handler_class_004.phpt] Test session_set_save_handler() : incomplete implementation [ext/session/tests/session_set_save_handler_class_005.phpt] Test session_set_save_handler() : manual shutdown, reopen [ext/session/tests/session_set_save_handler_class_007.phpt] Test session_set_save_handler() : manual shutdown [ext/session/tests/session_set_save_handler_class_008.phpt] Test session_set_save_handler() : implicit shutdown [ext/session/tests/session_set_save_handler_class_009.phpt] Test session_set_save_handler() : manual shutdown function [ext/session/tests/session_set_save_handler_class_010.phpt] Test session_set_save_handler() : incorrect arguments for existing handler open [ext/session/tests/session_set_save_handler_class_012.phpt] Test session_set_save_handler() : incorrect arguments for existing handler close [ext/session/tests/session_set_save_handler_class_013.phpt] A representative diff shows two kinds of issues: 003+ Read gjtkte0e3upfddc60pkuobqo40 004+ string(26) "gjtkte0e3upfddc60pkuobqo40" 003- Read %x 004- string(32) "%x" Chris -- Email: christopher.jones@oracle.com Tel: +1 650 506 8630 Blog: http://blogs.oracle.com/opal/