Re: Re: svn: /php/php-src/ branches/PHP_5_4/NEWS branches/PHP_5_4/Zend/tests/bug60169.phpt branches/PHP_5_4/Zend/zend_vm_def.h
branches/PHP_5_4/Zend/zend_vm_execute.h trunk/Zend/tests/bug60169.phpt trunk/Zend/zend_vm_def.h trunk/Zend/zend_v

Hi Arnaud : I am not sure that can we assume all the ptr_ptr is equal to the &(var.ptr) if we check this in fetch_dim_r if so, I think it's is a better fix. I will try to study further more :) and if you have a new fix, plz revert this. I am very glad with that there is a better way to fix it :) thanks On Thu, Nov 3, 2011 at 8:11 PM, Arnaud Le Blanc <arnaud.lb@gmail.com> wrote: > Hi laruence, > > Thanks for this. I didn't seen your comment on bug #60169 until now, and as > the bug was assigned to me I've also attempted to fix it and ended up with the > same fix :) > > However, I've noticed that there are other places setting ptr_ptr to NULL, and > they cause crashes too. > > For example, this crashes: > > $a = 1; > list($b) = $a->prop = 1; > > So I was wondering if we should always set ptr_ptr, or if we should check its > value in ZEND_FETCH_DIM_R instead. What do you think ? > > Best regards, > > Le Thursday 3 November 2011 04:59:41, Xinchen Hui a écrit : >> laruence                                 Thu, 03 Nov 2011 03:59:41 +0000 >> >> Revision: >> http://svn.php.net/viewvc?view=revision&revision=318716 >> >> Log: >> Fix bug #60169 Conjunction of ternary and list crashes PHP >> >> Bug: https://bugs.php.net/60169 (Assigned) Conjunction of >> ternary and list >> crashes PHP >> >> Changed paths: >>     U   php/php-src/branches/PHP_5_4/NEWS >>     U   php/php-src/branches/PHP_5_4/Zend/tests/bug60169.phpt >>     U   php/php-src/branches/PHP_5_4/Zend/zend_vm_def.h >>     U   php/php-src/branches/PHP_5_4/Zend/zend_vm_execute..h >>     U   php/php-src/trunk/Zend/tests/bug60169.phpt >>     U   php/php-src/trunk/Zend/zend_vm_def.h >>     U   php/php-src/trunk/Zend/zend_vm_execute.h > > -- > PHP CVS Mailing List (http://www.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php > > -- Laruence  Xinchen Hui http://www.laruence.com/