Re: svn: /php/php-src/ branches/PHP_5_3/ext/phar/tests/phar_oo_001.phpt branches/PHP_5_4/ext/phar/tests/phar_oo_001.phpt
trunk/ext/phar/tests/phar_oo_001.phpt
| From: | Hannes Magnusson | Date: | Sat, 05 Nov 2011 15:19:00 +0000 |
| Subject: | Re: svn: /php/php-src/ branches/PHP_5_3/ext/phar/tests/phar_oo_001.phpt branches/PHP_5_4/ext/phar/tests/phar_oo_001.phpt trunk/ext/phar/tests/phar_oo_001.phpt |
||
| References: | 1 2 3 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-66896@lists.php.net to get a copy of this message | ||
I believe Gustavo changed the behaviour again recently.
Don't have the time to check it out now though.
-Hannes
On Fri, Nov 4, 2011 at 21:06, Ferenc Kovacs <tyra3l@gmail.com> wrote:
> could you look into?
> I found it weird that the behavior was only changed for 5.3
>
> On Fri, Nov 4, 2011 at 9:05 PM, Ferenc Kovacs <tyra3l@gmail.com> wrote:
>
>> Hi.
>>
>> I see this test failing on http://ci.qa.php.net/ for 5.4
>> and trunk.
>>
>> 003+ string(50) "Cannot call method on an uninitialized Phar object"
>> 003- string(103) "In the constructor of MyPhar, parent::__construct() must be called
>> and its exceptions cannot be cleared"
>>
>>
>> On Mon, Aug 29, 2011 at 4:17 PM, Hannes Magnusson <bjori@php.net> wrote:
>>
>>> bjori Mon, 29 Aug 2011 14:17:41
>>> +0000
>>>
>>> Revision:
>>> http://svn.php.net/viewvc?view=revision&revision=315702
>>>
>>> Log:
>>> The Phar class extends RecursiveDirectoryIterator, which has changed the
>>> way it ensures its ctor is called
>>>
>>> Changed paths:
>>> U php/php-src/branches/PHP_5_3/ext/phar/tests/phar_oo_001.phpt
>>> U php/php-src/branches/PHP_5_4/ext/phar/tests/phar_oo_001.phpt
>>> U php/php-src/trunk/ext/phar/tests/phar_oo_001.phpt
>>>
>>> Modified: php/php-src/branches/PHP_5_3/ext/phar/tests/phar_oo_001.phpt
>>> ===================================================================
>>> --- php/php-src/branches/PHP_5_3/ext/phar/tests/phar_oo_001.phpt
>>> 2011-08-29 12:40:03 UTC (rev 315701)
>>> +++ php/php-src/branches/PHP_5_3/ext/phar/tests/phar_oo_001.phpt
>>> 2011-08-29 14:17:41 UTC (rev 315702)
>>> @@ -30,14 +30,14 @@
>>> $phar = new MyPhar();
>>> var_dump($phar->getVersion());
>>> }
>>> -catch (BadMethodCallException $e)
>>> +catch (LogicException $e)
>>> {
>>> var_dump($e->getMessage());
>>> }
>>> try {
>>> $phar = new Phar('test.phar');
>>> $phar->__construct('oops');
>>> -} catch (BadMethodCallException $e)
>>> +} catch (LogicException $e)
>>> {
>>> var_dump($e->getMessage());
>>> }
>>> @@ -52,6 +52,6 @@
>>> --EXPECT--
>>> string(5) "1.0.0"
>>> int(5)
>>> -string(50) "Cannot call method on an uninitialized Phar object"
>>> +string(103) "In the constructor of MyPhar, parent::__construct() must be
>>> called and its exceptions cannot be cleared"
>>> string(29) "Cannot call constructor twice"
>>> ===DONE===
>>>
>>> Modified: php/php-src/branches/PHP_5_4/ext/phar/tests/phar_oo_001.phpt
>>> ===================================================================
>>> --- php/php-src/branches/PHP_5_4/ext/phar/tests/phar_oo_001.phpt
>>> 2011-08-29 12:40:03 UTC (rev 315701)
>>> +++ php/php-src/branches/PHP_5_4/ext/phar/tests/phar_oo_001.phpt
>>> 2011-08-29 14:17:41 UTC (rev 315702)
>>> @@ -30,14 +30,14 @@
>>> $phar = new MyPhar();
>>> var_dump($phar->getVersion());
>>> }
>>> -catch (BadMethodCallException $e)
>>> +catch (LogicException $e)
>>> {
>>> var_dump($e->getMessage());
>>> }
>>> try {
>>> $phar = new Phar('test.phar');
>>> $phar->__construct('oops');
>>> -} catch (BadMethodCallException $e)
>>> +} catch (LogicException $e)
>>> {
>>> var_dump($e->getMessage());
>>> }
>>> @@ -52,6 +52,6 @@
>>> --EXPECT--
>>> string(5) "1.0.0"
>>> int(5)
>>> -string(50) "Cannot call method on an uninitialized Phar object"
>>> +string(103) "In the constructor of MyPhar, parent::__construct() must be
>>> called and its exceptions cannot be cleared"
>>> string(29) "Cannot call constructor twice"
>>> ===DONE===
>>>
>>> Modified: php/php-src/trunk/ext/phar/tests/phar_oo_001.phpt
>>> ===================================================================
>>> --- php/php-src/trunk/ext/phar/tests/phar_oo_001.phpt 2011-08-29
>>> 12:40:03 UTC (rev 315701)
>>> +++ php/php-src/trunk/ext/phar/tests/phar_oo_001.phpt 2011-08-29
>>> 14:17:41 UTC (rev 315702)
>>> @@ -30,14 +30,14 @@
>>> $phar = new MyPhar();
>>> var_dump($phar->getVersion());
>>> }
>>> -catch (BadMethodCallException $e)
>>> +catch (LogicException $e)
>>> {
>>> var_dump($e->getMessage());
>>> }
>>> try {
>>> $phar = new Phar('test.phar');
>>> $phar->__construct('oops');
>>> -} catch (BadMethodCallException $e)
>>> +} catch (LogicException $e)
>>> {
>>> var_dump($e->getMessage());
>>> }
>>> @@ -52,6 +52,6 @@
>>> --EXPECT--
>>> string(5) "1.0.0"
>>> int(5)
>>> -string(50) "Cannot call method on an uninitialized Phar object"
>>> +string(103) "In the constructor of MyPhar, parent::__construct() must be
>>> called and its exceptions cannot be cleared"
>>> string(29) "Cannot call constructor twice"
>>> ===DONE===
>>>
>>>
>>> --
>>> PHP CVS Mailing List (http://www.php.net/)
>>> To unsubscribe, visit: http://www.php.net/unsub.php
>>>
>>
>>
>>
>> --
>> Ferenc Kovács
>> @Tyr43l - http://tyrael.hu
>>
>
>
>
> --
> Ferenc Kovács
> @Tyr43l - http://tyrael.hu
>