Re: cvs: php4 /ext/sablot php_sablot.h

At 15:54 10-08-01, Rasmus Lerdorf wrote:

Modified files:

    /php4/ext/sablot  php_sablot.h

Log: There we go. Keep trying. You still didn't get them all.

I'd appreciate some help as I don't have an environment to build this.

I don't understand why you are forcing all extension authors to name their globals zend_*

They don't have to name them at all. They should just be using the macros, and using them everywhere. That's the whole point of the macros - making changes at one centralized place. Having two sets of macros is simply a bad thing - 2x places to fix and more opportunities to mess up. Regardless, the way you committed sablot.c was a hybrid of using macros and not using them, which just happened to build because you defined a variable of a certain name. It was still conceptually wrong. Zeev