Re: svn: /php/php-src/ branches/PHP_5_4/NEWS branches/PHP_5_4/Zend/zend_builtin_functions.c branches/PHP_5_4/ext/com_dotnet/com_typeinfo.c
branches/PHP_5_4/ext/oci8/oci8.c branches/PHP_5_4/ext/standard/syslog.c trunk/Zend/zend_builtin_funct
| From: | Kalle Sommer Nielsen | Date: | Fri, 18 Nov 2011 09:12:38 +0000 |
| Subject: | Re: svn: /php/php-src/ branches/PHP_5_4/NEWS branches/PHP_5_4/Zend/zend_builtin_functions.c branches/PHP_5_4/ext/com_dotnet/com_typeinfo.c branches/PHP_5_4/ext/oci8/oci8.c branches/PHP_5_4/ext/standard/syslog.c trunk/Zend/zend_builtin_funct |
||
| Groups: | php.cvs | ||
| Request: | Send a blank email to php-cvs+get-67031@lists.php.net to get a copy of this message | ||
Hi Stas
2011/11/18 Stanislav Malyshev <stas@php.net>:
> Modified: php/php-src/branches/PHP_5_4/Zend/zend_builtin_functions.c
> ===================================================================
> --- php/php-src/branches/PHP_5_4/Zend/zend_builtin_functions.c 2011-11-18 07:07:42 UTC (rev
> 319441)
> +++ php/php-src/branches/PHP_5_4/Zend/zend_builtin_functions.c 2011-11-18 07:11:19 UTC (rev
> 319442)
> @@ -706,6 +706,9 @@
> }
> c.flags = case_sensitive; /* non persistent */
> c.name = IS_INTERNED(name) ? name : zend_strndup(name, name_len);
> + if(name == NULL) {
> + RETURN_FALSE;
> + }
This looks wrong, as c.name have the return value of zend_strndup(), not name.
--
regards,
Kalle Sommer Nielsen
kalle@php.net