svn: /php/php-src/branches/PHP_5_3/ NEWS ext/standard/tests/general_functions/bug60227.phpt main/SAPI.c
| From: | Rui Hirokawa | Date: | Sat, 14 Jan 2012 07:41:01 +0000 |
| Subject: | svn: /php/php-src/branches/PHP_5_3/ NEWS ext/standard/tests/general_functions/bug60227.phpt main/SAPI.c | ||
| Groups: | php.cvs | ||
| Request: | Send a blank email to php-cvs+get-67445@lists.php.net to get a copy of this message | ||
hirokawa Sat, 14 Jan 2012 07:41:01 +0000
Revision: http://svn.php.net/viewvc?view=revision&revision=322263
Log:
MFH: fixed bug #60227: header() cannot detect the multi-line header with CR.
Bug: https://bugs.php.net/60227 (Closed) header() cannot
detect the multi-line header with CR(0x0D).
Changed paths:
U php/php-src/branches/PHP_5_3/NEWS
A php/php-src/branches/PHP_5_3/ext/standard/tests/general_functions/bug60227.phpt
U php/php-src/branches/PHP_5_3/main/SAPI.c
Modified: php/php-src/branches/PHP_5_3/NEWS
===================================================================
--- php/php-src/branches/PHP_5_3/NEWS 2012-01-14 06:47:23 UTC (rev 322262)
+++ php/php-src/branches/PHP_5_3/NEWS 2012-01-14 07:41:01 UTC (rev 322263)
@@ -1,5 +1,10 @@
PHP NEWS
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
+?? ?? 2012, PHP 5.3.10
+
+- Core:
+ . fixed bug #60227: header() cannot detect the multi-line header with CR (rui).
+
10 Jan 2012, PHP 5.3.9
- Core:
Added: php/php-src/branches/PHP_5_3/ext/standard/tests/general_functions/bug60227.phpt
===================================================================
--- php/php-src/branches/PHP_5_3/ext/standard/tests/general_functions/bug60227.phpt
(rev 0)
+++ php/php-src/branches/PHP_5_3/ext/standard/tests/general_functions/bug60227.phpt 2012-01-14
07:41:01 UTC (rev 322263)
@@ -0,0 +1,20 @@
+--TEST--
+Bug #60227 (header() cannot detect the multi-line header with CR)
+--FILE--
+<?php
+header("X-Foo1: a");
+header("X-Foo2: b\n ");
+header("X-Foo3: c\r\n ");
+header("X-Foo4: d\r ");
+header("X-Foo5: e\rSet-Cookie: ID=123");
+echo 'foo';
+?>
+--EXPECTF--
+Warning: Header may not contain more than a single header, new line detected. in %s on line %d
+foo
+--EXPECTHEADERS--
+X-Foo1: a
+X-Foo2: b
+X-Foo3: c
+X-Foo4: d
+
Property changes on: php/php-src/branches/PHP_5_3/ext/standard/tests/general_functions/bug60227.phpt
___________________________________________________________________
Added: svn:keywords
+ Id Rev Revision
Added: svn:eol-style
+ native
Modified: php/php-src/branches/PHP_5_3/main/SAPI.c
===================================================================
--- php/php-src/branches/PHP_5_3/main/SAPI.c 2012-01-14 06:47:23 UTC (rev 322262)
+++ php/php-src/branches/PHP_5_3/main/SAPI.c 2012-01-14 07:41:01 UTC (rev 322263)
@@ -592,7 +592,7 @@
} else {
/* new line safety check */
char *s = header_line, *e = header_line + header_line_len, *p;
- while (s < e && (p = memchr(s, '\n', (e - s)))) {
+ while (s < e && ((p = memchr(s, '\n', (e - s))) || (p = memchr(s,
'\r', (e - s))))) {
if (*(p + 1) == ' ' || *(p + 1) == '\t') {
s = p + 1;
continue;