Re: svn: /php/php-src/ branches/PHP_5_3/ext/pdo_sqlite/sqlite_driver.c branches/PHP_5_4/ext/pdo_sqlite/sqlite_driver.c
trunk/ext/pdo_sqlite/sqlite_driver.c
| From: | Pierre Joye | Date: | Wed, 01 Feb 2012 12:19:40 +0000 |
| Subject: | Re: svn: /php/php-src/ branches/PHP_5_3/ext/pdo_sqlite/sqlite_driver.c branches/PHP_5_4/ext/pdo_sqlite/sqlite_driver.c trunk/ext/pdo_sqlite/sqlite_driver.c |
||
| References: | 1 2 3 4 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-67588@lists.php.net to get a copy of this message | ||
we should enforce this flag.
2012/2/1 Johannes Schlüter <johannes@schlueters.de>:
> Setting CFLAGS=-Wdeclaration-after-statement makes gcc complain about
> this, too.
>
> johannes
>
> On Tue, 2012-01-31 at 21:07 +0100, Pierre Joye wrote:
>> hi,
>>
>> GCC is only being very bad at considering part of C99 as default.
>>
>> Cheers,
>>
>> On Tue, Jan 31, 2012 at 4:45 PM, Rasmus Lerdorf <rasmus@lerdorf.com> wrote:
>> > On 01/31/2012 02:14 AM, Pierre Joye wrote:
>> >
>> >> - struct pdo_sqlite_collation *collation;
>> >> -
>> >> while (H->collations) {
>> >> + struct pdo_sqlite_collation *collation;
>> >> collation = H->collations;
>> >> H->collations = collation->next;
>> >
>> > Why would this change fix anything? You are just tightening the scope of
>> > collation there? This compiled perfectly with gcc before this change.
>> >
>> > -Rasmus
>>
>>
>>
>> --
>> Pierre
>>
>> @pierrejoye | http://blog.thepimp.net |
>> http://www.libgd.org
>>
>
>
--
Pierre
@pierrejoye | http://blog.thepimp.net | http://www.libgd.org