svn: /php/php-src/trunk/ ext/standard/tests/general_functions/bug60227.phpt ext/standard/tests/general_functions/bug60227_1.phpt
ext/standard/tests/general_functions/bug60227_2.phpt main/SAPI.c

cataphract Thu, 02 Feb 2012 18:24:53 +0000 Revision: http://svn.php.net/viewvc?view=revision&revision=323033 Log: - Hopefully correct fix for bug #60227. #No commit for 5.4 for now Bug: https://bugs.php.net/60227 (Closed) header() cannot detect the multi-line header with CR(0x0D). Changed paths: D php/php-src/trunk/ext/standard/tests/general_functions/bug60227.phpt A + php/php-src/trunk/ext/standard/tests/general_functions/bug60227_1.phpt (from php/php-src/trunk/ext/standard/tests/general_functions/bug60227.phpt:r323031) A php/php-src/trunk/ext/standard/tests/general_functions/bug60227_2.phpt U php/php-src/trunk/main/SAPI.c Deleted: php/php-src/trunk/ext/standard/tests/general_functions/bug60227.phpt =================================================================== --- php/php-src/trunk/ext/standard/tests/general_functions/bug60227.phpt 2012-02-02 18:22:46 UTC (rev 323032) +++ php/php-src/trunk/ext/standard/tests/general_functions/bug60227.phpt 2012-02-02 18:24:53 UTC (rev 323033) @@ -1,20 +0,0 @@ ---TEST-- -Bug #60227 (header() cannot detect the multi-line header with CR) ---FILE-- -<?php -header("X-Foo1: a"); -header("X-Foo2: b\n "); -header("X-Foo3: c\r\n "); -header("X-Foo4: d\r "); -header("X-Foo5: e\rSet-Cookie: ID=123"); -echo 'foo'; -?> ---EXPECTF-- -Warning: Header may not contain more than a single header, new line detected. in %s on line %d -foo ---EXPECTHEADERS-- -X-Foo1: a -X-Foo2: b -X-Foo3: c -X-Foo4: d - Copied: php/php-src/trunk/ext/standard/tests/general_functions/bug60227_1.phpt (from rev 323031, php/php-src/trunk/ext/standard/tests/general_functions/bug60227.phpt) =================================================================== --- php/php-src/trunk/ext/standard/tests/general_functions/bug60227_1.phpt (rev 0) +++ php/php-src/trunk/ext/standard/tests/general_functions/bug60227_1.phpt 2012-02-02 18:24:53 UTC (rev 323033) @@ -0,0 +1,20 @@ +--TEST-- +Bug #60227 (header() cannot detect the multi-line header with CR) +--FILE-- +<?php +header("X-Foo1: a"); +header("X-Foo2: b\n "); +header("X-Foo3: c\r\n "); +header("X-Foo4: d\r "); +header("X-Foo5: e\rSet-Cookie: ID=123"); +echo 'foo'; +?> +--EXPECTF-- +Warning: Header may not contain more than a single header, new line detected. in %s on line %d +foo +--EXPECTHEADERS-- +X-Foo1: a +X-Foo2: b +X-Foo3: c +X-Foo4: d + Added: php/php-src/trunk/ext/standard/tests/general_functions/bug60227_2.phpt =================================================================== --- php/php-src/trunk/ext/standard/tests/general_functions/bug60227_2.phpt (rev 0) +++ php/php-src/trunk/ext/standard/tests/general_functions/bug60227_2.phpt 2012-02-02 18:24:53 UTC (rev 323033) @@ -0,0 +1,14 @@ +--TEST-- +Bug #60227 (header() cannot detect the multi-line header with CR), \r before \n +--FILE-- +<?php +header("X-foo: e\n foo"); +header("X-Foo6: e\rSet-Cookie: ID=123\n d"); +echo 'foo'; +?> +--EXPECTF-- +Warning: Header may not contain more than a single header, new line detected. in %s on line %d +foo +--EXPECTHEADERS-- +X-foo: e +foo Property changes on: php/php-src/trunk/ext/standard/tests/general_functions/bug60227_2.phpt ___________________________________________________________________ Added: svn:keywords + Id Rev Revision Added: svn:eol-style + native Modified: php/php-src/trunk/main/SAPI.c =================================================================== --- php/php-src/trunk/main/SAPI.c 2012-02-02 18:22:46 UTC (rev 323032) +++ php/php-src/trunk/main/SAPI.c 2012-02-02 18:24:53 UTC (rev 323033) @@ -711,10 +711,11 @@ return SUCCESS; } else { /* new line safety check */ - char *s = header_line, *e = header_line + header_line_len, *p; - while (s < e && ((p = memchr(s, '\n', (e - s))) || (p = memchr(s, '\r', (e - s))))) { - if (*(p + 1) == ' ' || *(p + 1) == '\t') { - s = p + 1; + char *s = header_line; + while (s = strpbrk(s, "\n\r")) { + if (s[1] == ' ' || s[1] == '\t') { + /* RFC 2616 allows new lines if followed by SP or HT */ + s++; continue; } efree(header_line);