Re: svn: /php/php-src/branches/PHP_5_ 4/ NEWS ext/standard/html.c ext/standard/tests/string s/bug60965.phpt
| From: | Gustavo Lopes | Date: | Sun, 05 Feb 2012 13:00:11 +0000 |
| Subject: | Re: svn: /php/php-src/branches/PHP_5_ 4/ NEWS ext/standard/html.c ext/standard/tests/string s/bug60965.phpt | ||
| References: | 1 2 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-67633@lists.php.net to get a copy of this message | ||
On Sun, 5 Feb 2012 10:55:39 -0000, Nuno Lopes wrote:
I didn't carefully review this patch, but doesn't this code suffer from potential math overflow? i.e. with strlen($input_str) > INT_MAX/2 (or UINT_MAX/2)All the length and position variables are of type size_t, so I'd say we'd be out of memory long before that could be a problem (unless there's some architecture of which I'm not aware where SIZE_T is low enough for this to be a problem). -- Gustavo Lopes