Re: com php-src: Add json_last_error_msg() function: ext/json/json.c ext/json/tests/003.phpt ext/json/tests/004.phpt ext/json/tests/007.phpt
ext/json/tests/bug54058.phpt ext/json/tests/bug61537.phpt ext/json/tests/inf_nan_error.phpt ext/jso
| From: | Laruence | Date: | Sun, 01 Jul 2012 03:27:27 +0000 |
| Subject: | Re: com php-src: Add json_last_error_msg() function: ext/json/json.c ext/json/tests/003.phpt ext/json/tests/004.phpt ext/json/tests/007.phpt ext/json/tests/bug54058.phpt ext/json/tests/bug61537.phpt ext/json/tests/inf_nan_error.phpt ext/jso |
||
| References: | 1 2 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-69504@lists.php.net to get a copy of this message | ||
On Sun, Jul 1, 2012 at 6:45 AM, Stas Malyshev <smalyshev@sugarcrm.com> wrote:
> Hi!
>
>>
>> I hope you picked this function name to fuel the "PHP is so
>> inconsistent" lovers. Could I suggest picking something a little less
>> a) different from everything else, and b) different from *everything*
>> else?
>>
>
> I think function name should be changed, and also all these big changes
> better belong to 5.5 than 5.3.
>
> I would propose renaming json_last_error to json_errno (keeping the
> json_last_error as an alias for BC) and having json_error as error
> message - just like all DB functions and many others do.
in this case,
I would suggest, json_errno, json_strerr, :)
thanks
> --
> Stanislav Malyshev, Software Architect
> SugarCRM: http://www.sugarcrm.com/
> (408)454-6900 ext. 227
>
> --
> PHP CVS Mailing List (http://www.php.net/)
> To unsubscribe, visit: http://www.php.net/unsub.php
>
--
Laruence Xinchen Hui
http://www.laruence.com/