Re: com php-src: fix (signed) integer overflow (part of bug #52550: Zend/zend_hash.h
| From: | Nuno Lopes | Date: | Sun, 08 Jul 2012 19:34:02 +0000 |
| Subject: | Re: com php-src: fix (signed) integer overflow (part of bug #52550: Zend/zend_hash.h | ||
| References: | 1 2 3 4 5 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-69539@lists.php.net to get a copy of this message | ||
Yes, it's equivalent. For subtle reasons which I'll save you from, but it is :) I've committed the fix. Thanks for your help! NunoOk. I don 't have a MSVC setup handy. Can you please test if replacing that line with 'idx = 0 - idx;' fixes the warnings for you?Seems to do the trick. Is 0- same as - for unsigned on all compilers (I know common sense says it should be but when compilers are concerned it's better to be sure :)