Re: com php-src: Added test for bug #51353. It'll be skipped by default and must be activated manually.: ext/zip/tests/bug51353.phpt
| From: | Anatoliy Belsky | Date: | Wed, 22 Aug 2012 08:11:41 +0000 |
| Subject: | Re: com php-src: Added test for bug #51353. It'll be skipped by default and must be activated manually.: ext/zip/tests/bug51353.phpt | ||
| References: | 1 2 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-69915@lists.php.net to get a copy of this message | ||
Hi Chris,
I've thought about that but the test takes about 20 minutes on my laptop,
that's pretty long. Do you think it'd be still ok?
Regards
Anatoliy
Am Mi, 22.08.2012, 02:18 schrieb Christopher Jones:
>
>
> On 8/21/12 4:22 AM, Anatoliy Belsky wrote:
>> Commit: 92153dcfe3f7643526572439622408d94fd4aa14
>> Author: Anatoliy Belsky <ab@php.net> Tue, 21 Aug 2012
>> 13:22:00 +0200
>> Parents: 0cdc1f5626bd400278aa193867e1fd4fe3f771d4
>> Branches: PHP-5.3 PHP-5.4 master
>>
>> Link:
>>
>> http://git.php.net/?p=php-src.git;a=commitdiff;h=92153dcfe3f7643526572439622408d94fd4aa14
>>
>> Log:
>> Added test for bug #51353. It'll be skipped by default and must be
>> activated manually.
>
>> +/* This test might get very long depending on the mashine it's running
>> on. Therefore
>> +adding an explicit skip, remove it to run this test. */
>
> What about enabling it unless SKIP_SLOW_TESTS is set?
>
> Chris
>
> --
> christopher.jones@oracle.com
> http://twitter.com/#!/ghrd
>