Re: cvs: php4 /ext/domxml php_domxml.c

Wouldn't it be better to just rename the existing alias? Better yet, why rename it at all? The API is changing anyway and adding BC stuff like this isn't really helping. (We should be going forwards. It's like..we take a step ahead and then some ministeps back.. :) This makes me think..should we just leave the domxml without any maintenance and let it die slowly and instead create new extension? :) --Jani On Tue, 21 Aug 2001, Joey Smith wrote: >joey Tue Aug 21 17:49:32 2001 EDT > > Modified files: > /php4/ext/domxml php_domxml.c > Log: > Some changes to help out previous users of domxml... > node::tagname == node::name. > Add property "type" to textnode types. > > >Index: php4/ext/domxml/php_domxml.c >diff -u php4/ext/domxml/php_domxml.c:1.67 php4/ext/domxml/php_domxml.c:1.68 >--- php4/ext/domxml/php_domxml.c:1.67 Tue Aug 14 04:23:22 2001 >+++ php4/ext/domxml/php_domxml.c Tue Aug 21 17:49:32 2001 >@@ -16,7 +16,7 @@ > +----------------------------------------------------------------------+ > */ > >-/* $Id: php_domxml.c,v 1.67 2001/08/14 08:23:22 joey Exp $ */ >+/* $Id: php_domxml.c,v 1.68 2001/08/21 21:49:32 joey Exp $ */ > > > #ifdef HAVE_CONFIG_H >@@ -191,6 +191,7 @@ > > static zend_function_entry php_domxmlelement_class_functions[] = { > PHP_FALIAS(domelement, domxml_element, NULL) >+ PHP_FALIAS(name, domxml_elem_tagname, NULL) > PHP_FALIAS(tagname, domxml_elem_tagname, NULL) > PHP_FALIAS(get_attribute, domxml_elem_get_attribute, NULL) > PHP_FALIAS(set_attribute, domxml_elem_set_attribute, NULL) >@@ -669,8 +670,10 @@ > object_init_ex(wrapper, domxmltext_class_entry); > rsrc_type = le_domxmltextp; > content = xmlNodeGetContent(nodep); >- if (content) >+ if (content) { >+ add_property_long(wrapper, "type", nodep->type); > add_property_stringl(wrapper, "content", (char *) content, strlen(content), 1); >+ } > break; > } > > > > >