com php-src: Fixed bug #60723 (error_log error time h as changed to UTC ignoring default timezo): e xt/standard/tests/general_functions/bug60723.phpt
main/main.c

Commit: 923511d364ad84500bb097aca15385129ce6e336 Author: Xinchen Hui <laruence@php.net> Sun, 23 Sep 2012 22:59:31 +0800 Parents: 2e8ab65270e7d1ebe1ef0dfe13836c29d72c7010 Branches: PHP-5.3 Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=923511d364ad84500bb097aca15385129ce6e336 Log: Fixed bug #60723 (error_log error time has changed to UTC ignoring default timezo) Cherry pick to 5.3 Bugs: https://bugs.php.net/60723 Changed paths: A ext/standard/tests/general_functions/bug60723.phpt M main/main.c Diff: diff --git a/ext/standard/tests/general_functions/bug60723.phpt b/ext/standard/tests/general_functions/bug60723.phpt new file mode 100644 index 0000000..cd73c8c --- /dev/null +++ b/ext/standard/tests/general_functions/bug60723.phpt @@ -0,0 +1,19 @@ +--TEST-- +Bug #55371 (get_magic_quotes_gpc() and get_magic_quotes_runtime() throw deprecated warning) +--INI-- +date.timezone=ASIA/Chongqing +log_errors=On +--FILE-- +<?php +$dir = dirname(__FILE__); +$log = $dir . "/tmp.err"; +ini_set("error_log", $log); +echo $aa; +error_log("dummy"); +readfile($log); +unlink($log); +?> +--EXPECTF-- +Notice: Undefined variable: aa in %sbug60723.php on line %d +[%s ASIA/Chongqing] PHP Notice: Undefined variable: aa in %sbug60723.php on line %d +[%s ASIA/Chongqing] dummy diff --git a/main/main.c b/main/main.c index 6506e10..631a6a9 100644 --- a/main/main.c +++ b/main/main.c @@ -600,7 +600,15 @@ PHPAPI void php_log_err(char *log_message TSRMLS_DC) char *error_time_str; time(&error_time); - error_time_str = php_format_date("d-M-Y H:i:s e", 13, error_time, 0 TSRMLS_CC); +#ifdef ZTS + if (!php_during_module_startup()) { + error_time_str = php_format_date("d-M-Y H:i:s e", 13, error_time, 1 TSRMLS_CC); + } else { + error_time_str = php_format_date("d-M-Y H:i:s e", 13, error_time, 0 TSRMLS_CC); + } +#else + error_time_str = php_format_date("d-M-Y H:i:s e", 13, error_time, 1 TSRMLS_CC); +#endif len = spprintf(&tmp, 0, "[%s] %s%s", error_time_str, log_message, PHP_EOL); #ifdef PHP_WIN32 php_flock(fd, 2);