com php-src: Fixed bug #63258 (seg fault with PDO and dblib using DBSETOPT(H->link, DBQUOTEDIDENT, 1)): NEWS ext/pdo_dblib/dbli b_driver.c
| From: | Xinchen Hui | Date: | Fri, 12 Oct 2012 02:37:05 +0000 |
| Subject: | com php-src: Fixed bug #63258 (seg fault with PDO and dblib using DBSETOPT(H->link, DBQUOTEDIDENT, 1)): NEWS ext/pdo_dblib/dbli b_driver.c | ||
| Groups: | php.cvs | ||
| Request: | Send a blank email to php-cvs+get-70331@lists.php.net to get a copy of this message | ||
Commit: 0c0b5a3543f37dc3dfe7fa55629f2749c0b05294
Author: Xinchen Hui <laruence@php.net> Fri, 12 Oct 2012 10:37:05 +0800
Parents: 07ea38b443bad0fc569047a288c6b1c081c7157f
Branches: PHP-5.4
Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=0c0b5a3543f37dc3dfe7fa55629f2749c0b05294
Log:
Fixed bug #63258 (seg fault with PDO and dblib using DBSETOPT(H->link, DBQUOTEDIDENT, 1))
The exists test should has covered this bug
Bugs:
https://bugs.php.net/63258
Changed paths:
M NEWS
M ext/pdo_dblib/dblib_driver.c
Diff:
diff --git a/NEWS b/NEWS
index 02fb131..d7f600a 100644
--- a/NEWS
+++ b/NEWS
@@ -60,6 +60,8 @@ PHP NEWS
SHA224, SHA256, SHA384, SHA512). (Mark Jones)
- PDO:
+ . Fixed bug #63258 (seg fault with PDO and dblib using DBSETOPT(H->link,
+ DBQUOTEDIDENT, 1)). (Laruence)
. Fixed bug #63235 (buffer overflow in use of SQLGetDiagRec).
(Martin Osvald, Remi)
diff --git a/ext/pdo_dblib/dblib_driver.c b/ext/pdo_dblib/dblib_driver.c
index 77832f9..baf1dcc 100644
--- a/ext/pdo_dblib/dblib_driver.c
+++ b/ext/pdo_dblib/dblib_driver.c
@@ -315,7 +315,7 @@ static int pdo_dblib_handle_factory(pdo_dbh_t *dbh, zval *driver_options TSRMLS_
DBSETOPT(H->link, DBTEXTSIZE, "2147483647");
/* allow double quoted indentifiers */
- DBSETOPT(H->link, DBQUOTEDIDENT, 1);
+ DBSETOPT(H->link, DBQUOTEDIDENT, NULL);
if (vars[3].optval && FAIL == dbuse(H->link, vars[3].optval)) {
goto cleanup;