Re: com php-src: Refactor to using a stack based zval instead of dynamic allocation: ext/standard/password.c

From: Date: Tue, 16 Oct 2012 21:40:51 +0000
Subject: Re: com php-src: Refactor to using a stack based zval instead of dynamic allocation: ext/standard/password.c
References: 1  Groups: php.cvs 
Request: Send a blank email to php-cvs+get-70405@lists.php.net to get a copy of this message
Hi, I gave a quick review to the overal implementation of this feature. A few comments: - php_password_make_salt() shouldn't allocate memory + do memcpy, but it should fill in 'ret' directly instead. Both mallocs can go away. - in PHP_FUNCTION(password_get_info) you assume that sscanf always succeeds. That's not the case if I pass a mis-encoded string. - in PHP_FUNCTION(password_hash) you don't need to estrndup the salt, since you're just reading it. - Similarly, no needs to emallocs and sprintf. You should write directly to the final string to avoid the copies. - The sprintf() there is probably not ok if the salt includes a \0 in the middle. In summary, there should be few or no mallocs in this file, since most buffers have a maximum (small) size that can be determined statically. Nuno

« previous php.cvs (#70405) next »