Re: com php-src: Test for #63336, xfail now: Zend/tests/bug63336.phpt

From: Date: Tue, 23 Oct 2012 08:46:03 +0000
Subject: Re: com php-src: Test for #63336, xfail now: Zend/tests/bug63336.phpt
References: 1  Groups: php.cvs 
Request: Send a blank email to php-cvs+get-70447@lists.php.net to get a copy of this message
Hi! > +class Base { > + const DUMMY = "XXX"; > + public function foo($var=TEST, $more=null) { return true; } > + public function bar($var, $more=self::DUMMY) { return true; } > +} > + > +class Child extends Base { > + const DUMMY = "DDD"; > + public function foo($var=TEST) { return true; } > + public function bar() { return true; } > +} > +?> > +--EXPECT-- > +Strict Standards: Declaration of Child::foo() should be compatible with Base::foo($var = > '123', $more = NULL) in %sbug63336.php on line %d > + > +Strict Standards: Declaration of Child::bar() should be compatible with Base::bar($var, $more > = 'XXX') in %sbug63336.php on line %d I don't think these are good examples for E_STRICT errors. bar() traditionally has been used in PHP as function accepting any arguments, so even if current implementation of PHP (wrongly) says it's not compatible it may be fixed in the future. I'd rather use more obvious cases where the extension is clearly wrong - like adding non-optional arguments or types. This bug has very little to do with compatibility resolution, so I do not think it is good to peg it to a particular way of doing it. -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227

« previous php.cvs (#70447) next »