Re: com php-src: These need to be volatile in order to prevent leaking after the longjmp in the error handler: ext/gd/libgd/gd_png.c
| From: | Rasmus Lerdorf | Date: | Wed, 07 Nov 2012 21:40:31 +0000 |
| Subject: | Re: com php-src: These need to be volatile in order to prevent leaking after the longjmp in the error handler: ext/gd/libgd/gd_png.c | ||
| References: | 1 2 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-70508@lists.php.net to get a copy of this message | ||
On 11/06/2012 12:06 PM, Nuno Lopes wrote:
> While I won't oppose this patch since it has no performance impact, I
> believe this is a bug in the compiler and not in the code below.
> The compiler should know about setjmp(). glibc, for example, marks that
> function with __attribute__((returns_twice)).
Yeah, I don't disagree, but I also don't see a problem with helping the
compiler a bit here and it fixes a leak which bit someone badly.
-Rasmus