com php-src: make failed tests fail the test target: Makefile.global
| From: | Lars Strojny | Date: | Sun, 11 Nov 2012 19:11:06 +0000 |
| Subject: | com php-src: make failed tests fail the test target: Makefile.global | ||
| Groups: | php.cvs | ||
| Request: | Send a blank email to php-cvs+get-70517@lists.php.net to get a copy of this message | ||
Commit: 180767373d03238431103c02a93de19df49c14dc
Author: Bernhard K.. Weisshuhn <bkw@codingforce.com> Sun, 11 Nov 2012 20:11:06
+0100
Parents: 4029475e82552a3ceddbdd343bdb5641eb269c50
Branches: master
Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=180767373d03238431103c02a93de19df49c14dc
Log:
make failed tests fail the test target
I don't see any reason to ignore failed tests. This makes it
unnecessarily difficult to use ci, also for module builds.
Changed paths:
M Makefile.global
Diff:
diff --git a/Makefile.global b/Makefile.global
index b30c318..eaf651e 100644
--- a/Makefile.global
+++ b/Makefile.global
@@ -86,7 +86,7 @@ PHP_TEST_SHARED_EXTENSIONS = ` \
PHP_DEPRECATED_DIRECTIVES_REGEX =
'^(magic_quotes_(gpc|runtime|sybase)?|(zend_)?extension(_debug)?(_ts)?)[\t\ ]*='
test: all
- -@if test ! -z "$(PHP_EXECUTABLE)" && test -x "$(PHP_EXECUTABLE)";
then \
+ @if test ! -z "$(PHP_EXECUTABLE)" && test -x "$(PHP_EXECUTABLE)"; then
\
INI_FILE=
$(PHP_EXECUTABLE) -d 'display_errors=stderr' -r 'echo
php_ini_loaded_file();' 2> /dev/null; \
if test "$$INI_FILE"; then \
$(EGREP) -h -v $(PHP_DEPRECATED_DIRECTIVES_REGEX) "$$INI_FILE" >
$(top_builddir)/tmp-php.ini; \