com php-src: Update arginfo for preg_match_all() to reflect reality.: ext/pcre/php_pcre.c
| From: | Adam Harvey | Date: | Mon, 12 Nov 2012 12:04:26 +0000 |
| Subject: | com php-src: Update arginfo for preg_match_all() to reflect reality.: ext/pcre/php_pcre.c | ||
| Groups: | php.cvs | ||
| Request: | Send a blank email to php-cvs+get-70519@lists.php.net to get a copy of this message | ||
Commit: bca8ff723d1d2721e410ecdf10955aea57445a19
Author: Adam Harvey <aharvey@php.net> Mon, 12 Nov 2012 20:04:26 +0800
Parents: 5b82fb52fd5143a3860db219eb39616c6e642a4b
Branches: PHP-5.4 master
Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=bca8ff723d1d2721e410ecdf10955aea57445a19
Log:
Update arginfo for preg_match_all() to reflect reality.
Back when I implemented FR #53238 during the 5.4 development phase to make the
$matches parameter optional in preg_match_all(), it turns out I forgot to
update the arginfo to note that only 2 parameters are now required by
preg_match_all(). The function itself works fine, but reflection was reporting
the wrong number of required parameters.
Bugs:
https://bugs.php.net/53238
Changed paths:
M ext/pcre/php_pcre.c
Diff:
diff --git a/ext/pcre/php_pcre.c b/ext/pcre/php_pcre.c
index 2f892c8..b18c9ed 100644
--- a/ext/pcre/php_pcre.c
+++ b/ext/pcre/php_pcre.c
@@ -1866,7 +1866,7 @@ ZEND_BEGIN_ARG_INFO_EX(arginfo_preg_match, 0, 0, 2)
ZEND_ARG_INFO(0, offset)
ZEND_END_ARG_INFO()
-ZEND_BEGIN_ARG_INFO_EX(arginfo_preg_match_all, 0, 0, 3)
+ZEND_BEGIN_ARG_INFO_EX(arginfo_preg_match_all, 0, 0, 2)
ZEND_ARG_INFO(0, pattern)
ZEND_ARG_INFO(0, subject)
ZEND_ARG_INFO(1, subpatterns) /* array */