Re: cvs: php4 /ext/domxml php_domxml.c

hi, this fragment is not correct IMO: > + if (! found) { > + *found = 0; > + } > + this is equiv to if (!found) { *(something *)NULL=0; } perhapse if (!*found) ? b. ----- Original Message ----- From: "Joey Smith" <joey@joeysmith.com> To: <php-cvs@lists.php.net> Sent: Tuesday, August 14, 2001 10:36 AM Subject: [PHP-CVS] cvs: php4 /ext/domxml php_domxml.c > joey Tue Aug 14 03:36:19 2001 EDT > > Modified files: > /php4/ext/domxml php_domxml.c > Log: > Don't hammer the resource type right off the bat. > > > Index: php4/ext/domxml/php_domxml.c > diff -u php4/ext/domxml/php_domxml.c:1.62 php4/ext/domxml/php_domxml.c:1.63 > --- php4/ext/domxml/php_domxml.c:1.62 Tue Aug 14 03:34:20 2001 > +++ php4/ext/domxml/php_domxml.c Tue Aug 14 03:36:18 2001 > @@ -16,7 +16,7 @@ > +----------------------------------------------------------------------+ > */ > > -/* $Id: php_domxml.c,v 1.62 2001/08/14 07:34:20 joey Exp $ */ > +/* $Id: php_domxml.c,v 1.63 2001/08/14 07:36:18 joey Exp $ */ > > > #ifdef HAVE_CONFIG_H > @@ -489,7 +489,10 @@ > { > zval *wrapper; > > - *found = 0; > + if (! found) { > + *found = 0; > + } > + > if (!obj) { > MAKE_STD_ZVAL(wrapper); > ZVAL_NULL(wrapper); > @@ -585,7 +588,10 @@ > zval *wrapper; > int rsrc_type; > > - *found = 0; > + if (! found) { > + *found = 0; > + } > + > if (!obj) { > MAKE_STD_ZVAL(wrapper); > ZVAL_NULL(wrapper); > @@ -660,7 +666,10 @@ > char *content; > int rsrc_type; > > - *found = 0; > + if (! found) { > + *found = 0; > + } > + > if (!obj) { > MAKE_STD_ZVAL(wrapper); > ZVAL_NULL(wrapper); > > > > -- > PHP CVS Mailing List (http://www.php.net/) > To unsubscribe, e-mail: php-cvs-unsubscribe@lists.php.net > For additional commands, e-mail: php-cvs-help@lists.php.net > To contact the list administrators, e-mail: php-list-admin@lists.php.net > >