Re: com php-src: Two tests deactivated until #63688 was fixed: tests/lang/034.phpt tests/lang/bug30638.phpt
| From: | Adam Harvey | Date: | Thu, 06 Dec 2012 01:32:27 +0000 |
| Subject: | Re: com php-src: Two tests deactivated until #63688 was fixed: tests/lang/034.phpt tests/lang/bug30638.phpt | ||
| References: | 1 2 3 4 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-70681@lists.php.net to get a copy of this message | ||
On 6 December 2012 06:24, Christopher Jones
<christopher.jones@oracle.com> wrote:
> On 12/05/2012 01:40 AM, Anatoliy Belsky wrote:
>>
>> That's a windows specific fail, the tests still pass on linux. XFAIL
>> would mark that wrong on linux, that's why.
>>
>> Regards
>>
>> Anatoliy
>
>
> Please leave them enabled in the meantime. Otherwise we have 0 coverage.
Alternatively, we could have two copies of the tests, with:
1. A phpt file that SKIPs on Windows and runs normally, and
2. A phpt file that SKIPs on non-Windows and is XFAIL.
Longer term, I know we have some other tests that would benefit from
platform specific XFAILs: tests/func/005a.phpt still failed only on OS
X last time I checked (due to a kernel bug we can't really work
around), for instance.
Adam