Re: com php-src: Remove a useless memory write in zend_llist_del_element: Zend/zend_llist.c
| From: | Stas Malyshev | Date: | Wed, 26 Dec 2012 06:31:52 +0000 |
| Subject: | Re: com php-src: Remove a useless memory write in zend_llist_del_element: Zend/zend_llist.c | ||
| References: | 1 2 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-70823@lists.php.net to get a copy of this message | ||
Hi!
>
>
> On 12/25/2012 05:45 PM, Pierrick Charron wrote:
>> Commit: fad960a4045da86cdbd8308a165ffc47892f05b9
>> Author: Pierrick Charron <pierrick@php.net> Tue, 25 Dec 2012 20:45:24
>> -0500
>> Parents: a2b6d9c1047a4e5f3419ebc3489a66d62aa12d07
>> Branches: PHP-5.3 PHP-5.4 PHP-5.5 master
>>
>> Link:
>> http://git.php.net/?p=php-src.git;a=commitdiff;h=fad960a4045da86cdbd8308a165ffc47892f05b9
>>
>> Log:
>> Remove a useless memory write in zend_llist_del_element
>>
>> The zend_llist_element *next pointer is not necessary and removing
>> it will also remove a write on memory
>
> Was this really worth potentially destabilizing 5.3 to change? Or even 5.4?
I don't think so. And BTW, why no asking maintainers about this? It's
not even a bug fix as far as I can see. Could you please do it in 5.5+?
--
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227