Re: com php-src: - Fixed ZTS build: Zend/zend_compile.c
| From: | Pierre Joye | Date: | Sat, 19 Jan 2013 13:07:05 +0000 |
| Subject: | Re: com php-src: - Fixed ZTS build: Zend/zend_compile.c | ||
| References: | 1 2 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-71025@lists.php.net to get a copy of this message | ||
Lars,
It would be nice if you do more tests before committing, that is:
- ZTS and NTS modes
- -std=c89 with gcc (so the declaration not being done on top of a
context will error out as well)
Thanks for your work!
On Sat, Jan 19, 2013 at 1:16 AM, Lars Strojny <lars@strojny.net> wrote:
> Thanks for fixing!
>
> Am 19.01.2013 um 01:15 schrieb Felipe Pena <felipe@php.net>:
>
>> Commit: e23fca8910b96f1c3bb26c6582c17c92fd6f2f7a
>> Author: Felipe Pena <felipensp@gmail.com> Fri, 18 Jan 2013 22:15:08 -0200
>> Parents: 087a1887022cbf7c3cc981c9ea8217f93736aa80
>> Branches: PHP-5.5 master
>>
>> Link: Ý
>> ‡ü¿/Ã’¸ÆuŸº¸¡http://git.php.net/?p=php-src.git;a=commitdiff;h=e23fca8910b96f1c3bb26c6582c17c92fd6f2f7a
>>
>> Log:
>> - Fixed ZTS build
>>
>> Changed paths:
>> M Zend/zend_compile.c
>>
>>
>> Diff:
>> diff --git a/Zend/zend_compile.c b/Zend/zend_compile.c
>> index b574ad6..10eac2d 100644
>> --- a/Zend/zend_compile.c
>> +++ b/Zend/zend_compile.c
>> @@ -2156,7 +2156,7 @@ void zend_do_resolve_class_name(znode *result, znode *class_name, int
>> is_static
>> zend_do_fetch_constant(result, class_name, &constant_name,
>> ZEND_RT, 1 TSRMLS_CC);
>> break;
>> case ZEND_FETCH_CLASS_DEFAULT:
>> - zend_resolve_class_name(class_name, ZEND_FETCH_CLASS_GLOBAL, 1);
>> + zend_resolve_class_name(class_name, ZEND_FETCH_CLASS_GLOBAL, 1
>> TSRMLS_CC);
>> *result = *class_name;
>> break;
>> }
>>
>>
>> --
>> PHP CVS Mailing List (http://www.php.net/)
>> To unsubscribe, visit: http://www.php.net/unsub.php
>>
>
>
> --
> PHP CVS Mailing List (http://www.php.net/)
> To unsubscribe, visit: http://www.php.net/unsub.php
>
--
Pierre
@pierrejoye | http://blog.thepimp.net | http://www.libgd.org