Re: com php-src: Fixed bug #64142 (dval to lval different behavior on ppc64): NEWS Zend/zend_operators.h
| From: | Stas Malyshev | Date: | Tue, 05 Feb 2013 07:54:55 +0000 |
| Subject: | Re: com php-src: Fixed bug #64142 (dval to lval different behavior on ppc64): NEWS Zend/zend_operators.h | ||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-71167@lists.php.net to get a copy of this message | ||
Hi!
> - if (d > LONG_MAX) {
> + if (d >= LONG_MAX) {
> return (long)(unsigned long) d;
> }
> return (long) d;
Could you please explain this one? I thought LONG_MAX is a largest
permissible long value, why when d==LONG_MAX we need to convert?
Also, why this patch - which seems to be a BC break since it exhibits
different behavior on 64-bit systems - needs to be in 5.4?
--
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227