Re: cvs: php4 /ext/pspell .cvsignore Makefile.in README config.m4 php_pspell.h pspell.c
| From: | Andrei Zmievski | Date: | Mon, 10 Jul 2000 22:24:51 +0000 |
| Subject: | Re: cvs: php4 /ext/pspell .cvsignore Makefile.in README config.m4 php_pspell.h pspell.c | ||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-713@lists.php.net to get a copy of this message | ||
On Mon, 10 Jul 2000, Vlad Krupin wrote:
> PHP_MINIT_FUNCTION(pspell){
> REGISTER_MAIN_LONG_CONSTANT("PS_FAST", PS_FAST, CONST_PERSISTENT | CONST_CS);
> REGISTER_MAIN_LONG_CONSTANT("PS_NORMAL", PS_NORMAL, CONST_PERSISTENT | CONST_CS);
> REGISTER_MAIN_LONG_CONSTANT("PS_BAD_SPELLERS", PS_BAD_SPELLERS, CONST_PERSISTENT |
> CONST_CS);
> le_pspell = register_list_destructors(php_pspell_close,NULL);
> return SUCCESS;
> }
I would suggest that you change these constants to start with PSPELL_.
PS_ is just too generic.
> /* {{{ proto int pspell_new(string language [, string spelling [, string jargon [, string
> encoding]]])
> Load a dictionary */
> PHP_FUNCTION(pspell_new){
> pval **language,**spelling,**jargon,**encoding;
Use zval please - pval is outdated.
-Andrei
"The human brain is a wonderful thing. It starts working the moment you
are born, and never stops until you stand up to speak in public. " -- Sir
George Jessel