Re: com php-src: Support for CLI process title (https://wiki.php.net/rfc/cli_process_title): sapi/cli/config.m4 sapi/cli/config.w32 sapi/cli/php_cli.c
sapi/cli/php_cli_process_title.c sapi/cli/php_cli_process_title.h sapi/cli/php_cli_server.c sapi/cli/php_cli_server.h sapi/cli/ps_title.c
sapi/cli/ps_title.h sapi/cli/tests/cli_process_title_unix.phpt sapi/cli/tests/cli_process_title_windows.phpt
| From: | Hannes Magnusson | Date: | Sat, 09 Mar 2013 23:04:44 +0000 |
| Subject: | Re: com php-src: Support for CLI process title (https://wiki.php.net/rfc/cli_process_title): sapi/cli/config.m4 sapi/cli/config.w32 sapi/cli/php_cli.c sapi/cli/php_cli_process_title.c sapi/cli/php_cli_process_title.h sapi/cli/php_cli_server.c sapi/cli/php_cli_server.h sapi/cli/ps_title.c sapi/cli/ps_title.h sapi/cli/tests/cli_process_title_unix.phpt sapi/cli/tests/cli_process_title_windows.phpt |
||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-71429@lists.php.net to get a copy of this message | ||
I'm still worried about the function name.
It will most probably be used by other sapis in the future too.
And I believe our naming convention says it should be "process_title_[set|get]".
-Hannes
On Thu, Mar 7, 2013 at 10:54 AM, Keyur Govande <keyur@php.net> wrote:
> Commit: a0a995cff356a6e7526188ad1979fac6c24b9e7e
> Author: Keyur Govande <kgovande@gmail.com> Thu, 7 Mar 2013 18:54:34 +0000
> Parents: d77eb411ea5d80379ee92a908f543b91fa293383
> Branches: master
>
> Link:
> http://git.php.net/?p=php-src.git;a=commitdiff;h=a0a995cff356a6e7526188ad1979fac6c24b9e7e
>
> Log:
> Support for CLI process title (https://wiki.php.net/rfc/cli_process_title)
>
> A new commit into branch 5.5
>
> Changed paths:
> M sapi/cli/config.m4
> M sapi/cli/config.w32
> M sapi/cli/php_cli.c
> A sapi/cli/php_cli_process_title.c
> A sapi/cli/php_cli_process_title.h
> M sapi/cli/php_cli_server.c
> M sapi/cli/php_cli_server.h
> A sapi/cli/ps_title.c
> A sapi/cli/ps_title.h
> A sapi/cli/tests/cli_process_title_unix.phpt
> A sapi/cli/tests/cli_process_title_windows.phpt
>
>
> --
> PHP CVS Mailing List (http://www.php.net/)
> To unsubscribe, visit: http://www.php.net/unsub.php