com php-src: Fixed possible resource leak: shared_alloc_win 32.c
| From: | Dmitry Stogov | Date: | Fri, 15 Feb 2013 13:46:38 +0000 |
| Subject: | com php-src: Fixed possible resource leak: shared_alloc_win 32.c | ||
| Groups: | php.cvs | ||
| Request: | Send a blank email to php-cvs+get-71537@lists.php.net to get a copy of this message | ||
Commit: bee06002d0fee1c440a5c5d04220a587416fdfb4
Author: Dmitry Stogov <dmitry@zend.com> Fri, 15 Feb 2013 17:46:38 +0400
Parents: 4c97b6c8cf7e9ff56be6511c9e4f40af1562b835
Branches: PHP-5.5 master
Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=bee06002d0fee1c440a5c5d04220a587416fdfb4
Log:
Fixed possible resource leak
Changed paths:
M shared_alloc_win32.c
Diff:
diff --git a/shared_alloc_win32.c b/shared_alloc_win32.c
index 4abf23d..32b7c3a 100644
--- a/shared_alloc_win32.c
+++ b/shared_alloc_win32.c
@@ -138,6 +138,7 @@ static int zend_shared_alloc_reattach(size_t requested_size, char **error_in)
err = GetLastError();
zend_win_error_message(ACCEL_LOG_FATAL, "Unable to read base address", err);
*error_in="read mapping base";
+ fclose(fp);
return ALLOC_FAILURE;
}
fclose(fp);
@@ -280,6 +281,7 @@ static int create_segments(size_t requested_size, zend_shared_segment ***shared_
if(!fp) {
zend_win_error_message(ACCEL_LOG_WARNING, mmap_base_file, err);
zend_win_error_message(ACCEL_LOG_FATAL, "Unable to write base address", err);
+ return ALLOC_FAILURE;
}
fprintf(fp, "%p\n", mapping_base);
fclose(fp);