Re: com php-src: Backported fix for bug #62852: NEWS ext/date/php_date.c ext/date/tests/bug62852.phpt ext/date/tests/bug62852_var2.phpt
ext/date/tests/bug62852_var3.phpt

Stas, The issue is that a warning wouldn't destroy that object. That object will occasionally segfault PHP. E_ERROR is the simplest solution which doesn't change the behavior of the normal operations. There is another one bug #53437. The patch there has E_ERROR as well, but for the same reason. A more permissive fix would involve even more behavior change as every method/use case of that inconsistent object should be checked. Regards Anatol On Wed, March 20, 2013 01:47, Stas Malyshev wrote: > Hi! > > >> + if (!php_date_initialize_from_hash(&return_value, &dateobj, myht >> TSRMLS_CC)) { >> + php_error(E_ERROR, "Invalid serialization data for DateTime object"); >> + } >> > > Why this is E_ERROR? Can't we recover from this problem? Bad > serialization data is E_NOTICE for unserialize(), why suddenly it becomes > fatal error? > > -- > Stanislav Malyshev, Software Architect > SugarCRM: http://www.sugarcrm.com/ > (408)454-6900 ext. 227 > >