Re: cvs: php4 /ext/standard rand_mt.c rand_sys.c

On Mon, 3 Sep 2001, Jeroen van Wolffelaar wrote: > > From what I can see from your patches, not everything is exactly > > working (ie, array_rand()), please do not commit something to the > > main/ branch unless its 100%. > > array_rand was buggy anyway (the algorithm is wrong), so instead of wasting > my time on a half-done patch, I rather fix the real problem, i.e. implement > an other algorithm. And to freely quote Zeev: That's fine, but don't place a php_error(E_ERROR, "") in there, leave it buggy, but working as expected. I see you've updated array_rand(), so that's better. > > "having the tree broken for a couple of hours or even some days is not a > complete disaster, because we're quite a time away from an release" > 1) that was a different situation, leading to an 8x speed improvement and great leaps in stability in the Thread Safe version of PHP. 2) (sorry Zeev :) Just cause Zeev said, don't mean its true. :) -Sterling