com php-src: Fix PDO::inTransaction() test for pgsql: ext/pdo_pgsql/tests/is_in_transaction.phpt
| From: | Nikita Popov | Date: | Sun, 24 Mar 2013 16:54:05 +0000 |
| Subject: | com php-src: Fix PDO::inTransaction() test for pgsql: ext/pdo_pgsql/tests/is_in_transaction.phpt | ||
| Groups: | php.cvs | ||
| Request: | Send a blank email to php-cvs+get-71719@lists.php.net to get a copy of this message | ||
Commit: c08e1d2be948d63f7a9309344a0ed4092ac8dace
Author: Nikita Popov <nikic@php.net> Sun, 24 Mar 2013 17:52:16 +0100
Parents: d9003828149380322e7b8d3e60c3001ae905f29c
Branches: PHP-5.5 master
Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=c08e1d2be948d63f7a9309344a0ed4092ac8dace
Log:
Fix PDO::inTransaction() test for pgsql
inTransaction() nowadays casts the in_transaction result to boolean.
I'm not sure whether the INERROR state should result in true or false.
For now I went with the result that we actually get.
Changed paths:
M ext/pdo_pgsql/tests/is_in_transaction.phpt
Diff:
diff --git a/ext/pdo_pgsql/tests/is_in_transaction.phpt b/ext/pdo_pgsql/tests/is_in_transaction.phpt
index 99ff561..72da4f4 100644
--- a/ext/pdo_pgsql/tests/is_in_transaction.phpt
+++ b/ext/pdo_pgsql/tests/is_in_transaction.phpt
@@ -57,10 +57,10 @@ var_dump($db->inTransaction());
?>
--EXPECT--
Test PDO::PGSQL_TRANSACTION_INTRANS
-int(2)
+bool(true)
Test PDO::PGSQL_TRANSACTION_IDLE
-int(0)
+bool(false)
Test PDO::PGSQL_TRANSACTION_INERROR
-int(3)
+bool(true)
Test PDO::PGSQL_TRANSACTION_IDLE
-int(0)
+bool(false)